diff options
| author | Noel Grandin <noel@peralex.com> | 2014-08-13 09:02:41 +0200 |
|---|---|---|
| committer | Noel Grandin <noel@peralex.com> | 2014-08-20 10:35:51 +0200 |
| commit | 252ed1708ad5a007e4c47c243595206650876a2b (patch) | |
| tree | b2a7a47f8a39c598c25355640a77022918c2d209 /toolkit | |
| parent | a240a78cc771a89febfe181abe78d2cf16e1970f (diff) | |
double-checked locking is not thread-safe in Java
found by PMD
Change-Id: Ibd4a9139c626932bec56c0b1dd32b4d59c8440b1
Diffstat (limited to 'toolkit')
| -rw-r--r-- | toolkit/qa/complex/toolkit/Assert.java | 2 | ||||
| -rw-r--r-- | toolkit/test/accessibility/AccessibleTextHandler.java | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/toolkit/qa/complex/toolkit/Assert.java b/toolkit/qa/complex/toolkit/Assert.java index 0bda0b65c242..eb6ec44dce1e 100644 --- a/toolkit/qa/complex/toolkit/Assert.java +++ b/toolkit/qa/complex/toolkit/Assert.java @@ -59,7 +59,7 @@ public class Assert catch ( NoSuchMethodException e ) { StringBuilder message = new StringBuilder(); - message.append( "no such method: " ).append( objectClass.getName() ).append( "." ).append( i_methodName ).append( "( " ); + message.append( "no such method: " ).append( objectClass.getName() ).append( '.' ).append( i_methodName ).append( "( " ); for ( int i=0; i<i_argClasses.length; ++i ) { message.append( i_argClasses[i].getName() ); diff --git a/toolkit/test/accessibility/AccessibleTextHandler.java b/toolkit/test/accessibility/AccessibleTextHandler.java index 39ecbad6e4bc..acd2f0208005 100644 --- a/toolkit/test/accessibility/AccessibleTextHandler.java +++ b/toolkit/test/accessibility/AccessibleTextHandler.java @@ -249,11 +249,11 @@ class AccessibleTextHandler extends NodeHandler StringBuffer aChars = new StringBuffer(); try { - aChars.append( "[" ); + aChars.append( '[' ); for( int i = 0; i < nChars; i++) { aChars.append( xText.getCharacter(i) ); - aChars.append( "," ); + aChars.append( ',' ); } if( nChars > 0) { @@ -262,7 +262,7 @@ class AccessibleTextHandler extends NodeHandler else aChars.append( "..." ); } - aChars.append( "]" ); + aChars.append( ']' ); } catch( IndexOutOfBoundsException e ) { |