diff options
author | Caolán McNamara <caolanm@redhat.com> | 2015-01-29 09:07:25 +0000 |
---|---|---|
committer | Caolán McNamara <caolanm@redhat.com> | 2015-01-29 23:42:26 +0000 |
commit | 309574394bd4ae3e9e10e5ff0d64bdd7bbbc8b83 (patch) | |
tree | f8b8cea0a81bc74ca34e8bda2d0dfce939b28ce0 /toolkit | |
parent | 20deac4903fc0697477e855feeff482b3da234f9 (diff) |
callcatcher: large newly detected unused methods post de-virtualization
i.e lots now able to be detected after...
commit b44cbb26efe1d0b0950b1e1613e131b506dc3876
Author: Noel Grandin <noel@peralex.com>
Date: Tue Jan 20 12:38:10 2015 +0200
new loplugin: change virtual methods to non-virtual
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
Diffstat (limited to 'toolkit')
-rw-r--r-- | toolkit/qa/complex/toolkit/accessibility/_XAccessibleComponent.java | 1 | ||||
-rw-r--r-- | toolkit/source/awt/vclxgraphics.cxx | 48 | ||||
-rw-r--r-- | toolkit/source/controls/accessiblecontrolcontext.cxx | 7 |
3 files changed, 0 insertions, 56 deletions
diff --git a/toolkit/qa/complex/toolkit/accessibility/_XAccessibleComponent.java b/toolkit/qa/complex/toolkit/accessibility/_XAccessibleComponent.java index 5788452f6477..3d4df2c5ff19 100644 --- a/toolkit/qa/complex/toolkit/accessibility/_XAccessibleComponent.java +++ b/toolkit/qa/complex/toolkit/accessibility/_XAccessibleComponent.java @@ -40,7 +40,6 @@ import com.sun.star.uno.XInterface; * <li><code> getLocationOnScreen()</code></li> * <li><code> getSize()</code></li> * <li><code> grabFocus()</code></li> - * <li><code> getAccessibleKeyBinding()</code></li> * </ul> <p> * * @see com.sun.star.accessibility.XAccessibleComponent diff --git a/toolkit/source/awt/vclxgraphics.cxx b/toolkit/source/awt/vclxgraphics.cxx index cfc6b152e27a..0c92655da6a7 100644 --- a/toolkit/source/awt/vclxgraphics.cxx +++ b/toolkit/source/awt/vclxgraphics.cxx @@ -184,23 +184,6 @@ void VCLXGraphics::setFont( const uno::Reference< awt::XFont >& rxFont ) throw(u maFont = VCLUnoHelper::CreateFont( rxFont ); } -uno::Reference< awt::XFont > VCLXGraphics::getFont() throw(uno::RuntimeException) -{ - uno::Reference< awt::XFont > xFont; - uno::Reference< awt::XDevice > xDevice( getDevice() ); - - SolarMutexGuard aGuard; - - if ( xDevice.is() ) - { - VCLXFont *pFont = new VCLXFont; - pFont->Init( *xDevice.get(), maFont ); - xFont.set( static_cast< ::cppu::OWeakObject* >( pFont ), uno::UNO_QUERY ); - } - - return xFont; -} - void VCLXGraphics::selectFont( const awt::FontDescriptor& rDescription ) throw(uno::RuntimeException, std::exception) { SolarMutexGuard aGuard; @@ -215,12 +198,6 @@ void VCLXGraphics::setTextColor( sal_Int32 nColor ) throw(uno::RuntimeException, maTextColor = Color( (sal_uInt32)nColor ); } -::sal_Int32 VCLXGraphics::getTextColor() throw(uno::RuntimeException) -{ - SolarMutexGuard aGuard; - return maTextColor.GetColor(); -} - void VCLXGraphics::setTextFillColor( sal_Int32 nColor ) throw(uno::RuntimeException, std::exception) { SolarMutexGuard aGuard; @@ -228,12 +205,6 @@ void VCLXGraphics::setTextFillColor( sal_Int32 nColor ) throw(uno::RuntimeExcept maTextFillColor = Color( (sal_uInt32)nColor ); } -::sal_Int32 VCLXGraphics::getTextFillColor() throw(uno::RuntimeException) -{ - SolarMutexGuard aGuard; - return maTextFillColor.GetColor(); -} - void VCLXGraphics::setLineColor( sal_Int32 nColor ) throw(uno::RuntimeException, std::exception) { SolarMutexGuard aGuard; @@ -241,12 +212,6 @@ void VCLXGraphics::setLineColor( sal_Int32 nColor ) throw(uno::RuntimeException, maLineColor = Color( (sal_uInt32)nColor ); } -::sal_Int32 VCLXGraphics::getLineColor() throw(uno::RuntimeException) -{ - SolarMutexGuard aGuard; - return maLineColor.GetColor(); -} - void VCLXGraphics::setFillColor( sal_Int32 nColor ) throw(uno::RuntimeException, std::exception) { SolarMutexGuard aGuard; @@ -254,12 +219,6 @@ void VCLXGraphics::setFillColor( sal_Int32 nColor ) throw(uno::RuntimeException, maFillColor = Color( (sal_uInt32)nColor ); } -::sal_Int32 VCLXGraphics::getFillColor() throw(uno::RuntimeException) -{ - SolarMutexGuard aGuard; - return maFillColor.GetColor(); -} - void VCLXGraphics::setRasterOp( awt::RasterOperation eROP ) throw(uno::RuntimeException, std::exception) { SolarMutexGuard aGuard; @@ -267,13 +226,6 @@ void VCLXGraphics::setRasterOp( awt::RasterOperation eROP ) throw(uno::RuntimeEx meRasterOp = (RasterOp)eROP; } -awt::RasterOperation VCLXGraphics::getRasterOp() -throw(uno::RuntimeException) -{ - SolarMutexGuard aGuard; - return (awt::RasterOperation) meRasterOp; -} - void VCLXGraphics::setClipRegion( const uno::Reference< awt::XRegion >& rxRegion ) throw(uno::RuntimeException, std::exception) { SolarMutexGuard aGuard; diff --git a/toolkit/source/controls/accessiblecontrolcontext.cxx b/toolkit/source/controls/accessiblecontrolcontext.cxx index b384af37139c..d8084d46832e 100644 --- a/toolkit/source/controls/accessiblecontrolcontext.cxx +++ b/toolkit/source/controls/accessiblecontrolcontext.cxx @@ -313,13 +313,6 @@ namespace toolkit } - Any SAL_CALL OAccessibleControlContext::getAccessibleKeyBinding( ) throw (RuntimeException) - { - // we do not have any key bindings to activate a UNO control in design mode - return Any(); - } - - sal_Int32 SAL_CALL OAccessibleControlContext::getForeground( ) throw (::com::sun::star::uno::RuntimeException, std::exception) { SolarMutexGuard aSolarGuard; |