diff options
author | dante <dante19031999@gmail.com> | 2020-11-08 14:32:57 +0100 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-11-11 06:51:22 +0100 |
commit | f3b52717e85621d3b4ee1c6d69700e2a0cca8efc (patch) | |
tree | aa4df032b1ab661ad19b3ebc2e8e2c59babb4b07 /tools/source | |
parent | 3d90997fb6f232d8008df4d166d7b97b869c200f (diff) |
Improved starmath color
Color.hxx has now documentation ( even if it is quite obvious if you know RGB standar ).
Color.hxx has been reordered in more coherent order, but kept format.
Some changes on Color.hxx dynamics.
Color.hxx starmath colors list
Now colors are managed by starmathdatabse.
The path is open for simple addition of colors, there are no more infinite switches with color tokens here and there.
To add a color, just put it in Color.hxx and register it in starmathdatabse.cxx. Do not forget to change array size in starmathdatabase.hxx.
Now mathml supports RGB colors in #RRGGBB format ( import and export ).
New colors have been added. Only the HTML Css1 are available via UI.
New colors will be added. I intend to finish Css2 and dvipsnames ( latex colors ) on posterior patches.
RGBA command has been unlocked for compatibility reasons. However will be displayed as RGB.
Added color #RRGGBB.
Improved qa color test on mathml to test RGB on mathml.
TODO for someone on the UI team:
- Add a color picker.
- If it is a color with name:
- It will add in the code "color " + starmathdatabase::Identify_Color_DVIPSNAMES( colorvalue ).pIdent +" "
- If not:
- It will add in the code "color " + starmathdatabase::Identify_Color_DVIPSNAMES( colorvalue ).pIdent +" "+ colorvalue.getRed() +" "+ colorvalue.getGreen() +" "+ colorvalue.getBlue() +" "
- Note that those will habe eType with value TRGB or TRGBA.
Change-Id: I47af37bd191b3099e8e6e08e7a5fb1a8a227bbf2
Change-Id: If971473ddcc34739439818dba9a62ca3494a4473
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105526
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'tools/source')
-rw-r--r-- | tools/source/generic/color.cxx | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/tools/source/generic/color.cxx b/tools/source/generic/color.cxx index 73be2beaf6de..2b7c5cc35102 100644 --- a/tools/source/generic/color.cxx +++ b/tools/source/generic/color.cxx @@ -56,16 +56,6 @@ void Color::DecreaseContrast(sal_uInt8 nContDec) } } -bool Color::IsDark() const -{ - return GetLuminance() <= 60; -} - -bool Color::IsBright() const -{ - return GetLuminance() >= 245; -} - // color space conversion void Color::RGBtoHSB( sal_uInt16& nHue, sal_uInt16& nSat, sal_uInt16& nBri ) const |