diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-08-04 11:37:34 +0200 |
|---|---|---|
| committer | Michael Meeks <michael.meeks@collabora.com> | 2021-09-16 19:01:07 +0200 |
| commit | 712c5d7090abea828aff57f199879a7897211680 (patch) | |
| tree | d2e24d74769c1fbc8cd448bbcb4a15169cc44519 /tools | |
| parent | d65e177242f2e7359e17161af5f5092daacc34eb (diff) | |
improve LOK notifyInvalidation
(*) tweak buffer in SfxLokHelper::notifyInvalidation to be a bit larger,
so we avoid the cost of a resize©
(*) use our optimised OString concatentation instead of going via
std::stringstream
(*) pass down a pointer to rectangle, instead of a string. later we will
use this to avoid doing the stringify until later
Change-Id: Ia3e3042bc919d9b9cb80e47a93704eb236438605
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119994
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120072
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit 417f881d20cafe88a02b64894ba4483875fb9460)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122123
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/source/generic/gen.cxx | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/tools/source/generic/gen.cxx b/tools/source/generic/gen.cxx index 78025c459d07..e16d85698c0e 100644 --- a/tools/source/generic/gen.cxx +++ b/tools/source/generic/gen.cxx @@ -29,12 +29,10 @@ OString Pair::toString() const { - std::stringstream ss; // Note that this is not just used for debugging output but the // format is parsed by external code (passed in callbacks to // LibreOfficeKit clients). So don't change. - ss << A() << ", " << B(); - return ss.str().c_str(); + return OString::number(A()) + ", " + OString::number(B()); } tools::Rectangle tools::Rectangle::Justify( const Point& rLT, const Point& rRB ) @@ -194,12 +192,10 @@ bool tools::Rectangle::IsOver( const tools::Rectangle& rRect ) const OString tools::Rectangle::toString() const { - std::stringstream ss; // Note that this is not just used for debugging output but the // format is parsed by external code (passed in callbacks to // LibreOfficeKit clients). So don't change. - ss << getX() << ", " << getY() << ", " << getWidth() << ", " << getHeight(); - return ss.str().c_str(); + return OString::number(getX()) + ", " + OString::number(getY()) + ", " + OString::number(getWidth()) + ", " + OString::number(getHeight()); } void tools::Rectangle::expand(tools::Long nExpandBy) |