Extend loplugin:external to warn about classes

...following up on 314f15bff08b76bf96acf99141776ef64d2f1355 "Extend
loplugin:external to warn about enums".

Cases where free functions were moved into an unnamed namespace along with a
class, to not break ADL, are in:

filter/source/svg/svgexport.cxx
sc/source/filter/excel/xelink.cxx
sc/source/filter/excel/xilink.cxx
svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx

All other free functions mentioning moved classes appear to be harmless and not
give rise to (silent, even) ADL breakage.  (One remaining TODO in
compilerplugins/clang/external.cxx is that derived classes are not covered by
computeAffectedTypes, even though they could also be affected by ADL-breakage---
but don't seem to be in any acutal case across the code base.)

For friend declarations using elaborate type specifiers, like

class C1 {};
class C2 { friend class C1; };

* If C2 (but not C1) is moved into an unnamed namespace, the friend declaration
must be changed to not use an elaborate type specifier (i.e., "friend C1;"; see
C++17 [namespace.memdef]/3: "If the name in a friend declaration is neither
qualified nor a template-id and the declaration is a function or an
elaborated-type-specifier, the lookup to determine whether the entity has been
previously declared shall not consider any scopes outside the innermost
enclosing namespace.")

* If C1 (but not C2) is moved into an unnamed namespace, the friend declaration
must be changed too, see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71882>
"elaborated-type-specifier friend not looked up in unnamed namespace".

Apart from that, to keep changes simple and mostly mechanical (which should help
avoid regressions), out-of-line definitions of class members have been left in
the enclosing (named) namespace.  But explicit specializations of class
templates had to be moved into the unnamed namespace to appease
<https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92598> "explicit specialization of
template from unnamed namespace using unqualified-id in enclosing namespace".

Also, accompanying declarations (of e.g. typedefs or static variables) that
could arguably be moved into the unnamed namespace too have been left alone.

And in some cases, mention of affected types in blacklists in other loplugins
needed to be adapted.

And sc/qa/unit/mark_test.cxx uses a hack of including other .cxx, one of which
is sc/source/core/data/segmenttree.cxx where e.g. ScFlatUInt16SegmentsImpl is
not moved into an unnamed namespace (because it is declared in
sc/inc/segmenttree.hxx), but its base ScFlatSegmentsImpl is.  GCC warns about
such combinations with enabled-by-default -Wsubobject-linkage, but "The compiler
doesn’t give this warning for types defined in the main .C file, as those are
unlikely to have multiple definitions."
(<https://gcc.gnu.org/onlinedocs/gcc-9.2.0/gcc/Warning-Options.html>)  The
warned-about classes also don't have multiple definitions in the given test, so
disable the warning when including the .cxx.

Change-Id: Ib694094c0d8168be68f8fe90dfd0acbb66a3f1e4
Reviewed-on: https://gerrit.libreoffice.org/83239
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

4 files changed, 25 insertions, 0 deletions

diff --git a/tools/source/debug/debug.cxx b/tools/source/debug/debug.cxx
index de4a14015044..a410b6feeaa9 100644
--- a/tools/source/debug/debug.cxx
+++ b/tools/source/debug/debug.cxx
@@ -63,6 +63,8 @@
 
 #ifndef NDEBUG
 
+namespace {
+
 struct DebugData
 {
     DbgTestSolarMutexProc   pDbgTestSolarMutex;
@@ -74,6 +76,8 @@ struct DebugData
     }
 };
 
+}
+
 static DebugData aDebugData;
 
 void DbgSetTestSolarMutex( DbgTestSolarMutexProc pParam )
diff --git a/tools/source/generic/config.cxx b/tools/source/generic/config.cxx
index fe760decf852..6808bc4a132a 100644
--- a/tools/source/generic/config.cxx
+++ b/tools/source/generic/config.cxx
@@ -29,6 +29,8 @@
 #include <tools/config.hxx>
 #include <sal/log.hxx>
 
+namespace {
+
 struct ImplKeyData
 {
     ImplKeyData*    mpNext;
@@ -37,6 +39,8 @@ struct ImplKeyData
     bool            mbIsComment;
 };
 
+}
+
 struct ImplGroupData
 {
     ImplGroupData*  mpNext;
diff --git a/tools/source/generic/poly.cxx b/tools/source/generic/poly.cxx
index 0a597fdff1fc..7c9ece60693b 100644
--- a/tools/source/generic/poly.cxx
+++ b/tools/source/generic/poly.cxx
@@ -639,6 +639,8 @@ void ImplPolygon::ImplCreateFlagArray()
     }
 }
 
+namespace {
+
 class ImplPointFilter
 {
 public:
@@ -670,6 +672,8 @@ public:
     ImplPolygon&    get() { return maPoly; }
 };
 
+}
+
 void ImplPolygonPointFilter::Input( const Point& rPoint )
 {
     if ( !mnSize || (rPoint != maPoly.mxPointAry[mnSize-1]) )
@@ -687,6 +691,8 @@ void ImplPolygonPointFilter::LastPoint()
         maPoly.ImplSetSize( mnSize );
 };
 
+namespace {
+
 class ImplEdgePointFilter : public ImplPointFilter
 {
     Point               maFirstPoint;
@@ -721,6 +727,8 @@ public:
     virtual void        LastPoint() override;
 };
 
+}
+
 inline int ImplEdgePointFilter::VisibleSide( const Point& rPoint ) const
 {
     if ( mnEdge & EDGE_HORZ )
@@ -1219,6 +1227,8 @@ void Polygon::AdaptiveSubdivide( Polygon& rResult, const double d ) const
     }
 }
 
+namespace {
+
 class Vector2D
 {
 private:
@@ -1233,6 +1243,9 @@ public:
     bool         IsPositive( Vector2D const & rVec ) const { return ( mfX * rVec.mfY - mfY * rVec.mfX ) >= 0.0; }
     bool         IsNegative( Vector2D const & rVec ) const { return !IsPositive( rVec ); }
 };
+
+}
+
 Vector2D& Vector2D::Normalize()
 {
     double fLen = Scalar( *this );
diff --git a/tools/source/reversemap/bestreversemap.cxx b/tools/source/reversemap/bestreversemap.cxx
index 90679654cbbe..83b642368caa 100644
--- a/tools/source/reversemap/bestreversemap.cxx
+++ b/tools/source/reversemap/bestreversemap.cxx
@@ -13,6 +13,8 @@
 #include <cstdlib>
 #include <stdio.h>
 
+namespace {
+
 struct Encoder
 {
     rtl_UnicodeToTextConverter const m_aConverter;
@@ -55,6 +57,8 @@ struct Encoder
 
 };
 
+}
+
 int main()
 {
 #   define EXP(x) Encoder(x, #x)