diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-08-04 11:37:34 +0200 |
|---|---|---|
| committer | Michael Meeks <michael.meeks@collabora.com> | 2021-08-04 18:23:34 +0200 |
| commit | 5a76932c9f53bd35a83f3f956d4cbd693b88bfee (patch) | |
| tree | 02342b6598128ecf340a724a84c495b4af9d4648 /tools | |
| parent | 40272c9a9b2c554d34cbb942a6fab2e7977dd549 (diff) | |
improve LOK notifyInvalidation
(*) tweak buffer in SfxLokHelper::notifyInvalidation to be a bit larger,
so we avoid the cost of a resize©
(*) use our optimised OString concatentation instead of going via
std::stringstream
(*) pass down a pointer to rectangle, instead of a string. later we will
use this to avoid doing the stringify until later
Change-Id: Ia3e3042bc919d9b9cb80e47a93704eb236438605
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119994
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/source/generic/gen.cxx | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/tools/source/generic/gen.cxx b/tools/source/generic/gen.cxx index 7c182818c460..d7360af6419c 100644 --- a/tools/source/generic/gen.cxx +++ b/tools/source/generic/gen.cxx @@ -29,12 +29,10 @@ OString Pair::toString() const { - std::stringstream ss; // Note that this is not just used for debugging output but the // format is parsed by external code (passed in callbacks to // LibreOfficeKit clients). So don't change. - ss << A() << ", " << B(); - return ss.str().c_str(); + return OString::number(A()) + ", " + OString::number(B()); } void tools::Rectangle::SetSize( const Size& rSize ) @@ -185,12 +183,10 @@ bool tools::Rectangle::IsOver( const tools::Rectangle& rRect ) const OString tools::Rectangle::toString() const { - std::stringstream ss; // Note that this is not just used for debugging output but the // format is parsed by external code (passed in callbacks to // LibreOfficeKit clients). So don't change. - ss << getX() << ", " << getY() << ", " << getWidth() << ", " << getHeight(); - return ss.str().c_str(); + return OString::number(getX()) + ", " + OString::number(getY()) + ", " + OString::number(getWidth()) + ", " + OString::number(getHeight()); } void tools::Rectangle::expand(long nExpandBy) |