teach lolugin:stringconstant about calling constructors

so we can remove unnecessary calls to the OUString(literal) constructor
when calling constructors like this:
Foo(OUString("xxx"), 1)

Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36
Reviewed-on: https://gerrit.libreoffice.org/33698
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

4 files changed, 15 insertions, 15 deletions

diff --git a/ucb/source/ucp/file/bc.cxx b/ucb/source/ucp/file/bc.cxx
index 6f45334bc53f..cfd21fda6fe4 100644
--- a/ucb/source/ucp/file/bc.cxx
+++ b/ucb/source/ucp/file/bc.cxx
@@ -377,7 +377,7 @@ BaseContent::execute( const Command& aCommand,
     {
         Sequence< beans::Property > seq(1);
         seq[0] = beans::Property(
-            OUString("CasePreservingURL"),
+            "CasePreservingURL",
             -1,
             cppu::UnoType<sal_Bool>::get(),
             0 );
@@ -480,7 +480,7 @@ BaseContent::getContentType()
             {
                 // Who am I ?
                 Sequence< beans::Property > seq(1);
-                seq[0] = beans::Property( OUString("IsDocument"),
+                seq[0] = beans::Property( "IsDocument",
                                           -1,
                                           cppu::UnoType<sal_Bool>::get(),
                                           0 );
@@ -598,7 +598,7 @@ BaseContent::createNewContent( const ContentInfo& Info )
     try
     {
         Sequence< beans::Property > seq(1);
-        seq[0] = beans::Property( OUString("IsDocument"),
+        seq[0] = beans::Property( "IsDocument",
                                   -1,
                                   cppu::UnoType<sal_Bool>::get(),
                                   0 );
@@ -1031,7 +1031,7 @@ BaseContent::transfer( sal_Int32 nMyCommandIdentifier,
 
     // Is destination a document or a folder ?
     Sequence< beans::Property > seq(1);
-    seq[0] = beans::Property( OUString("IsDocument"),
+    seq[0] = beans::Property( "IsDocument",
                               -1,
                               cppu::UnoType<sal_Bool>::get(),
                               0 );
@@ -1097,7 +1097,7 @@ void SAL_CALL BaseContent::insert( sal_Int32 nMyCommandIdentifier,
     bool bDocument = false;
 
     Sequence< beans::Property > seq(1);
-    seq[0] = beans::Property( OUString("IsDocument"),
+    seq[0] = beans::Property( "IsDocument",
                               -1,
                               cppu::UnoType<sal_Bool>::get(),
                               0 );
diff --git a/ucb/source/ucp/file/filglob.cxx b/ucb/source/ucp/file/filglob.cxx
index 9700d66ddbca..32010ebf050e 100644
--- a/ucb/source/ucp/file/filglob.cxx
+++ b/ucb/source/ucp/file/filglob.cxx
@@ -120,25 +120,25 @@ namespace {
                                     (bRemoveProperty ? 1 : 0) );
         sal_Int32 i = 0;
         aArguments[i++]
-            <<= PropertyValue(OUString( "Uri"),
+            <<= PropertyValue("Uri",
                               -1,
                               makeAny(rPhysicalUrl),
                               PropertyState_DIRECT_VALUE);
         if (bResourceName)
             aArguments[i++]
-                <<= PropertyValue(OUString( "ResourceName"),
+                <<= PropertyValue("ResourceName",
                                   -1,
                                   makeAny(aResourceName),
                                   PropertyState_DIRECT_VALUE);
         if (bResourceType)
             aArguments[i++]
-                <<= PropertyValue(OUString( "ResourceType"),
+                <<= PropertyValue("ResourceType",
                                   -1,
                                   makeAny(aResourceType),
                                   PropertyState_DIRECT_VALUE);
         if (bRemoveProperty)
             aArguments[i++]
-                <<= PropertyValue(OUString( "Removable"),
+                <<= PropertyValue("Removable",
                                   -1,
                                   makeAny(bRemovable),
                                   PropertyState_DIRECT_VALUE);
diff --git a/ucb/source/ucp/file/filtask.cxx b/ucb/source/ucp/file/filtask.cxx
index 653289b13a5c..9c534b50c6fb 100644
--- a/ucb/source/ucp/file/filtask.cxx
+++ b/ucb/source/ucp/file/filtask.cxx
@@ -965,7 +965,7 @@ TaskManager::setv( const OUString& aUnqPath,
                         --propChanged; // unsuccessful setting
                         uno::Sequence< uno::Any > names( 1 );
                         ret[0] <<= beans::PropertyValue(
-                            OUString("Uri"), -1,
+                            "Uri", -1,
                             uno::makeAny(aUnqPath),
                             beans::PropertyState_DIRECT_VALUE);
                         IOErrorCode ioError(IOErrorCode_GENERAL);
@@ -1029,7 +1029,7 @@ TaskManager::setv( const OUString& aUnqPath,
                         --propChanged; // unsuccessful setting
                         uno::Sequence< uno::Any > names( 1 );
                         names[0] <<= beans::PropertyValue(
-                            OUString("Uri"), -1,
+                            "Uri", -1,
                             uno::makeAny(aUnqPath),
                             beans::PropertyState_DIRECT_VALUE);
                         IOErrorCode ioError;
@@ -3048,7 +3048,7 @@ uno::Sequence< ucb::ContentInfo > TaskManager::queryCreatableContentsInfo()
 
     uno::Sequence< beans::Property > props( 1 );
     props[0] = beans::Property(
-        OUString("Title"),
+        "Title",
         -1,
         cppu::UnoType<OUString>::get(),
         beans::PropertyAttribute::MAYBEVOID
diff --git a/ucb/source/ucp/file/prov.cxx b/ucb/source/ucp/file/prov.cxx
index 5552d016a43b..eeb5c75a1a4b 100644
--- a/ucb/source/ucp/file/prov.cxx
+++ b/ucb/source/ucp/file/prov.cxx
@@ -281,17 +281,17 @@ private:
 XPropertySetInfoImpl2::XPropertySetInfoImpl2()
     : m_seq( 3 )
 {
-    m_seq[0] = Property( OUString("HostName"),
+    m_seq[0] = Property( "HostName",
                          -1,
                          cppu::UnoType<OUString>::get(),
                          PropertyAttribute::READONLY );
 
-    m_seq[1] = Property( OUString("HomeDirectory"),
+    m_seq[1] = Property( "HomeDirectory",
                          -1,
                          cppu::UnoType<OUString>::get(),
                          PropertyAttribute::READONLY );
 
-    m_seq[2] = Property( OUString("FileSystemNotation"),
+    m_seq[2] = Property( "FileSystemNotation",
                          -1,
                          cppu::UnoType<sal_Int32>::get(),
                          PropertyAttribute::READONLY );