diff options
| author | Michael Stahl <michael.stahl@allotropia.de> | 2021-10-11 20:04:44 +0200 |
|---|---|---|
| committer | Michael Stahl <michael.stahl@allotropia.de> | 2021-11-01 18:47:12 +0100 |
| commit | df2a39fc61ad33d1c5cd81141c4c4f76a493dc9d (patch) | |
| tree | a3a4c138fd6e6c7cdd50bac5b2a5a8029b2c65fb /ucb/source/ucp | |
| parent | 6e423be3a811bd44902290b0db48754ef1a59f1b (diff) | |
ucb: webdav-curl: add additional comments from commit...
... 827cc09948c09d934dd32ca1867252618f761eab - the code was already
there.
Change-Id: I90b0c617bf060adffd6912529b8fff7897069162
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123487
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Diffstat (limited to 'ucb/source/ucp')
| -rw-r--r-- | ucb/source/ucp/webdav-curl/webdavcontent.cxx | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/ucb/source/ucp/webdav-curl/webdavcontent.cxx b/ucb/source/ucp/webdav-curl/webdavcontent.cxx index 6f24f1269e89..f0a0f9baeb0c 100644 --- a/ucb/source/ucp/webdav-curl/webdavcontent.cxx +++ b/ucb/source/ucp/webdav-curl/webdavcontent.cxx @@ -100,7 +100,7 @@ void lcl_sendPartialGETRequest( bool &bError, DAVRequestHeaders aPartialGet; aPartialGet.push_back( DAVRequestHeader( - OUString( "Range" ), + OUString( "Range" ), // see <https://tools.ietf.org/html/rfc7233#section-3.1> OUString( "bytes=0-0" ))); bool bIsRequestSize = std::any_of(aHeaderNames.begin(), aHeaderNames.end(), @@ -110,8 +110,8 @@ void lcl_sendPartialGETRequest( bool &bError, { // we need to know if the server accepts range requests for a resource // and the range unit it uses - aHeaderNames.push_back( OUString( "Accept-Ranges" ) ); - aHeaderNames.push_back( OUString( "Content-Range" ) ); + aHeaderNames.push_back( OUString( "Accept-Ranges" ) ); // see <https://tools.ietf.org/html/rfc7233#section-2.3> + aHeaderNames.push_back( OUString( "Content-Range" ) ); // see <https://tools.ietf.org/html/rfc7233#section-4.2> } try { @@ -1498,6 +1498,7 @@ uno::Reference< sdbc::XRow > Content::getPropertyValues( aLastException.getStatus() == SC_METHOD_NOT_ALLOWED || aLastException.getStatus() == SC_NOT_FOUND ) { + SAL_WARN( "ucb.ucp.webdav", "HEAD not implemented: fall back to a partial GET" ); lcl_sendPartialGETRequest( bError, aLastException, aMissingProps, |