diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2024-04-19 12:41:54 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2024-04-20 10:01:23 +0200 |
| commit | c9bf1e18bd80098d5498c831ee4586d04f003053 (patch) | |
| tree | 28cab7f6c4fe1340313685fa7073d59da2302a3c /ucb/source | |
| parent | 7e0b8e74dd6de7a337ab08a8be2921aeef765117 (diff) | |
loplugin:constantparam in ucb,unotools
Change-Id: I4161adac7544e7b1a8a7d8e18a3ae6c72ca77062
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166310
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'ucb/source')
| -rw-r--r-- | ucb/source/ucp/webdav-curl/DAVAuthListener.hxx | 3 | ||||
| -rw-r--r-- | ucb/source/ucp/webdav-curl/DAVAuthListenerImpl.hxx | 3 | ||||
| -rw-r--r-- | ucb/source/ucp/webdav-curl/DAVResourceAccess.cxx | 7 |
3 files changed, 5 insertions, 8 deletions
diff --git a/ucb/source/ucp/webdav-curl/DAVAuthListener.hxx b/ucb/source/ucp/webdav-curl/DAVAuthListener.hxx index c3d643bc7d82..f5c2392185c1 100644 --- a/ucb/source/ucp/webdav-curl/DAVAuthListener.hxx +++ b/ucb/source/ucp/webdav-curl/DAVAuthListener.hxx @@ -34,8 +34,7 @@ class DAVAuthListener : public salhelper::SimpleReferenceObject const OUString & inHostName, OUString & inoutUserName, OUString & outPassWord, - bool bCanUseSystemCredentials, - bool bUsePreviousCredentials = true ) = 0; + bool bCanUseSystemCredentials) = 0; }; } // namespace http_dav_ucp diff --git a/ucb/source/ucp/webdav-curl/DAVAuthListenerImpl.hxx b/ucb/source/ucp/webdav-curl/DAVAuthListenerImpl.hxx index 700c7c4c61ae..b0e6302bcf6d 100644 --- a/ucb/source/ucp/webdav-curl/DAVAuthListenerImpl.hxx +++ b/ucb/source/ucp/webdav-curl/DAVAuthListenerImpl.hxx @@ -46,8 +46,7 @@ namespace http_dav_ucp const OUString & inHostName, OUString & inoutUserName, OUString & outPassWord, - bool bCanUseSystemCredentials, - bool bUsePreviousCredentials = true ) override; + bool bCanUseSystemCredentials ) override; private: const css::uno::Reference< css::ucb::XCommandEnvironment > m_xEnv; diff --git a/ucb/source/ucp/webdav-curl/DAVResourceAccess.cxx b/ucb/source/ucp/webdav-curl/DAVResourceAccess.cxx index c1b775c08f70..dfe78feb2454 100644 --- a/ucb/source/ucp/webdav-curl/DAVResourceAccess.cxx +++ b/ucb/source/ucp/webdav-curl/DAVResourceAccess.cxx @@ -47,8 +47,7 @@ int DAVAuthListener_Impl::authenticate( const OUString & inHostName, OUString & inoutUserName, OUString & outPassWord, - bool bCanUseSystemCredentials, - bool bUsePreviousCredentials ) + bool bCanUseSystemCredentials ) { if ( m_xEnv.is() ) { @@ -61,10 +60,10 @@ int DAVAuthListener_Impl::authenticate( // container to reject these. Thus, the credential input dialog will be shown again. // #102871# - Supply username and password from previous try. // Password container service depends on this! - if ( inoutUserName.isEmpty() && bUsePreviousCredentials ) + if ( inoutUserName.isEmpty() ) inoutUserName = m_aPrevUsername; - if ( outPassWord.isEmpty() && bUsePreviousCredentials ) + if ( outPassWord.isEmpty() ) outPassWord = m_aPrevPassword; rtl::Reference< ucbhelper::SimpleAuthenticationRequest > xRequest |