loplugin:stringviewparam extend to comparison operators

which means that some call sites have to change to use
unicode string literals i.e. u"foo" instead of "foo"

Change-Id: Ie51c3adf56d343dd1d1710777f9d2a43ee66221c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106125
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

3 files changed, 12 insertions, 12 deletions

diff --git a/ucb/source/cacher/cachedcontentresultset.cxx b/ucb/source/cacher/cachedcontentresultset.cxx
index 483b7e3fcb74..9e713839e082 100644
--- a/ucb/source/cacher/cachedcontentresultset.cxx
+++ b/ucb/source/cacher/cachedcontentresultset.cxx
@@ -374,10 +374,10 @@ private:
 
     bool
     impl_queryProperty(
-            const OUString& rName
+            std::u16string_view rName
             , css::beans::Property& rProp ) const;
     sal_Int32
-    impl_getPos( const OUString& rName ) const;
+    impl_getPos( std::u16string_view rName ) const;
 
     static bool
     impl_isMyPropertyName( const OUString& rName );
@@ -411,8 +411,8 @@ public:
 //some helping variables ( names for my special properties )
 const char g_sPropertyNameForCount[] = "RowCount";
 const char g_sPropertyNameForFinalCount[] = "IsRowCountFinal";
-const char g_sPropertyNameForFetchSize[] = "FetchSize";
-const char g_sPropertyNameForFetchDirection[] = "FetchDirection";
+constexpr OUStringLiteral g_sPropertyNameForFetchSize(u"FetchSize");
+constexpr OUStringLiteral g_sPropertyNameForFetchDirection(u"FetchDirection");
 
 CCRS_PropertySetInfo::CCRS_PropertySetInfo(
         Reference< XPropertySetInfo > const & xInfo )
@@ -543,7 +543,7 @@ sal_Bool SAL_CALL CCRS_PropertySetInfo
 
 
 sal_Int32 CCRS_PropertySetInfo
-            ::impl_getPos( const OUString& rName ) const
+            ::impl_getPos( std::u16string_view rName ) const
 {
     for( sal_Int32 nN = m_pProperties->getLength(); nN--; )
     {
@@ -555,7 +555,7 @@ sal_Int32 CCRS_PropertySetInfo
 }
 
 bool CCRS_PropertySetInfo
-        ::impl_queryProperty( const OUString& rName, Property& rProp ) const
+        ::impl_queryProperty( std::u16string_view rName, Property& rProp ) const
 {
     for( const Property& rMyProp : std::as_const(*m_pProperties) )
     {
diff --git a/ucb/source/ucp/ftp/ftpcontentprovider.cxx b/ucb/source/ucp/ftp/ftpcontentprovider.cxx
index 72e427e22934..3f10357c395f 100644
--- a/ucb/source/ucp/ftp/ftpcontentprovider.cxx
+++ b/ucb/source/ucp/ftp/ftpcontentprovider.cxx
@@ -186,9 +186,9 @@ CURL* FTPContentProvider::handle()
 }
 
 
-void FTPContentProvider::forHost( const OUString& host,
-                                  const OUString& port,
-                                  const OUString& username,
+void FTPContentProvider::forHost( std::u16string_view host,
+                                  std::u16string_view port,
+                                  std::u16string_view username,
                                   OUString& password,
                                   OUString& account)
 {
diff --git a/ucb/source/ucp/ftp/ftpcontentprovider.hxx b/ucb/source/ucp/ftp/ftpcontentprovider.hxx
index 093ddf6e9f64..00a4fa1acc89 100644
--- a/ucb/source/ucp/ftp/ftpcontentprovider.hxx
+++ b/ucb/source/ucp/ftp/ftpcontentprovider.hxx
@@ -74,9 +74,9 @@ namespace ftp
         /** host is in the form host:port.
          */
 
-        void forHost(const OUString& host,
-                             const OUString& port,
-                             const OUString& username,
+        void forHost(std::u16string_view host,
+                             std::u16string_view port,
+                             std::u16string_view username,
                              OUString& password,
                              OUString& account);