diff options
author | Noel Grandin <noel@peralex.com> | 2016-04-12 12:08:00 +0200 |
---|---|---|
committer | Noel Grandin <noelgrandin@gmail.com> | 2016-04-14 11:37:19 +0000 |
commit | 62633dfe026bc3badf7066e5fb454036bae9cfdc (patch) | |
tree | b1a30ddd709ba80b8629d916d54c03d733651d12 /ucb | |
parent | aa458c31a5dfa2be8b6bd8f1b4e402ce8c27edde (diff) |
clang-tidy performance-unnecessary-value-param in various
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907
Reviewed-on: https://gerrit.libreoffice.org/24019
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'ucb')
-rw-r--r-- | ucb/source/cacher/cachedcontentresultsetstub.cxx | 8 | ||||
-rw-r--r-- | ucb/source/cacher/cachedcontentresultsetstub.hxx | 8 | ||||
-rw-r--r-- | ucb/source/core/FileAccess.cxx | 2 | ||||
-rw-r--r-- | ucb/source/sorter/sortresult.cxx | 10 | ||||
-rw-r--r-- | ucb/source/sorter/sortresult.hxx | 10 | ||||
-rw-r--r-- | ucb/source/ucp/cmis/cmis_content.cxx | 8 | ||||
-rw-r--r-- | ucb/source/ucp/cmis/cmis_content.hxx | 6 | ||||
-rw-r--r-- | ucb/source/ucp/gio/gio_content.cxx | 6 | ||||
-rw-r--r-- | ucb/source/ucp/gio/gio_content.hxx | 6 |
9 files changed, 32 insertions, 32 deletions
diff --git a/ucb/source/cacher/cachedcontentresultsetstub.cxx b/ucb/source/cacher/cachedcontentresultsetstub.cxx index 8064360140fb..ba0c5758b8cd 100644 --- a/ucb/source/cacher/cachedcontentresultsetstub.cxx +++ b/ucb/source/cacher/cachedcontentresultsetstub.cxx @@ -332,7 +332,7 @@ sal_Int32 SAL_CALL CachedContentResultSetStub void SAL_CALL CachedContentResultSetStub ::impl_getCurrentRowContent( Any& rRowContent - , Reference< XRow > xRow ) + , const Reference< XRow >& xRow ) throw ( SQLException, RuntimeException ) { sal_Int32 nCount = impl_getColumnCount(); @@ -437,7 +437,7 @@ void SAL_CALL CachedContentResultSetStub void SAL_CALL CachedContentResultSetStub ::impl_getCurrentContentIdentifierString( Any& rAny - , Reference< XContentAccess > xContentAccess ) + , const Reference< XContentAccess >& xContentAccess ) throw ( RuntimeException ) { rAny <<= xContentAccess->queryContentIdentifierString(); @@ -445,7 +445,7 @@ void SAL_CALL CachedContentResultSetStub void SAL_CALL CachedContentResultSetStub ::impl_getCurrentContentIdentifier( Any& rAny - , Reference< XContentAccess > xContentAccess ) + , const Reference< XContentAccess >& xContentAccess ) throw ( RuntimeException ) { rAny <<= xContentAccess->queryContentIdentifier(); @@ -453,7 +453,7 @@ void SAL_CALL CachedContentResultSetStub void SAL_CALL CachedContentResultSetStub ::impl_getCurrentContent( Any& rAny - , Reference< XContentAccess > xContentAccess ) + , const Reference< XContentAccess >& xContentAccess ) throw ( RuntimeException ) { rAny <<= xContentAccess->queryContent(); diff --git a/ucb/source/cacher/cachedcontentresultsetstub.hxx b/ucb/source/cacher/cachedcontentresultsetstub.hxx index 9157d9791c4c..979310010a73 100644 --- a/ucb/source/cacher/cachedcontentresultsetstub.hxx +++ b/ucb/source/cacher/cachedcontentresultsetstub.hxx @@ -54,7 +54,7 @@ private: void SAL_CALL impl_getCurrentRowContent( css::uno::Any& rRowContent, - css::uno::Reference< css::sdbc::XRow > xRow ) + const css::uno::Reference< css::sdbc::XRow >& xRow ) throw ( css::sdbc::SQLException , css::uno::RuntimeException ); @@ -64,19 +64,19 @@ private: static void SAL_CALL impl_getCurrentContentIdentifierString( css::uno::Any& rAny - , css::uno::Reference< css::ucb::XContentAccess > xContentAccess ) + , const css::uno::Reference< css::ucb::XContentAccess >& xContentAccess ) throw ( css::uno::RuntimeException ); static void SAL_CALL impl_getCurrentContentIdentifier( css::uno::Any& rAny - , css::uno::Reference< css::ucb::XContentAccess > xContentAccess ) + , const css::uno::Reference< css::ucb::XContentAccess >& xContentAccess ) throw ( css::uno::RuntimeException ); static void SAL_CALL impl_getCurrentContent( css::uno::Any& rAny - , css::uno::Reference< css::ucb::XContentAccess > xContentAccess ) + , const css::uno::Reference< css::ucb::XContentAccess >& xContentAccess ) throw ( css::uno::RuntimeException ); void SAL_CALL diff --git a/ucb/source/core/FileAccess.cxx b/ucb/source/core/FileAccess.cxx index f386d14e69ca..6ec2fefc423d 100644 --- a/ucb/source/core/FileAccess.cxx +++ b/ucb/source/core/FileAccess.cxx @@ -167,7 +167,7 @@ class OCommandEnvironment : public cppu::WeakImplHelper< XCommandEnvironment > Reference< XInteractionHandler > mxInteraction; public: - void setHandler( Reference< XInteractionHandler > xInteraction_ ) + void setHandler( const Reference< XInteractionHandler >& xInteraction_ ) { mxInteraction = xInteraction_; } diff --git a/ucb/source/sorter/sortresult.cxx b/ucb/source/sorter/sortresult.cxx index 43c7493740d4..55271af4cf5c 100644 --- a/ucb/source/sorter/sortresult.cxx +++ b/ucb/source/sorter/sortresult.cxx @@ -963,8 +963,8 @@ void SAL_CALL SortedResultSet::removeVetoableChangeListener( // private methods -sal_IntPtr SortedResultSet::CompareImpl( Reference < XResultSet > xResultOne, - Reference < XResultSet > xResultTwo, +sal_IntPtr SortedResultSet::CompareImpl( const Reference < XResultSet >& xResultOne, + const Reference < XResultSet >& xResultTwo, sal_IntPtr nIndexOne, sal_IntPtr nIndexTwo, SortInfo* pSortInfo ) @@ -1178,8 +1178,8 @@ sal_IntPtr SortedResultSet::CompareImpl( Reference < XResultSet > xResultOne, } -sal_IntPtr SortedResultSet::CompareImpl( Reference < XResultSet > xResultOne, - Reference < XResultSet > xResultTwo, +sal_IntPtr SortedResultSet::CompareImpl( const Reference < XResultSet >& xResultOne, + const Reference < XResultSet >& xResultTwo, sal_IntPtr nIndexOne, sal_IntPtr nIndexTwo ) throw( SQLException, RuntimeException ) { @@ -1617,7 +1617,7 @@ void SortedResultSet::Move( sal_IntPtr nPos, sal_IntPtr nCount, sal_IntPtr nOffs void SortedResultSet::BuildSortInfo( - Reference< XResultSet > aResult, + const Reference< XResultSet >& aResult, const Sequence < NumberedSortingInfo > &xSortInfo, const Reference< XAnyCompareFactory > &xCompFactory ) { diff --git a/ucb/source/sorter/sortresult.hxx b/ucb/source/sorter/sortresult.hxx index e2461f44b568..9ee45c55a245 100644 --- a/ucb/source/sorter/sortresult.hxx +++ b/ucb/source/sorter/sortresult.hxx @@ -145,16 +145,16 @@ private: sal_IntPtr Compare( SortListData *pOne, SortListData *pTwo ) throw( css::sdbc::SQLException, css::uno::RuntimeException ); - void BuildSortInfo( css::uno::Reference< css::sdbc::XResultSet > aResult, + void BuildSortInfo( const css::uno::Reference< css::sdbc::XResultSet >& aResult, const css::uno::Sequence < css::ucb::NumberedSortingInfo > &xSortInfo, const css::uno::Reference< css::ucb::XAnyCompareFactory > &xCompFac ); - static sal_IntPtr CompareImpl( css::uno::Reference < css::sdbc::XResultSet > xResultOne, - css::uno::Reference < css::sdbc::XResultSet > xResultTwo, + static sal_IntPtr CompareImpl( const css::uno::Reference < css::sdbc::XResultSet >& xResultOne, + const css::uno::Reference < css::sdbc::XResultSet >& xResultTwo, sal_IntPtr nIndexOne, sal_IntPtr nIndexTwo, SortInfo* pSortInfo ) throw( css::sdbc::SQLException, css::uno::RuntimeException ); - sal_IntPtr CompareImpl( css::uno::Reference < css::sdbc::XResultSet > xResultOne, - css::uno::Reference < css::sdbc::XResultSet > xResultTwo, + sal_IntPtr CompareImpl( const css::uno::Reference < css::sdbc::XResultSet >& xResultOne, + const css::uno::Reference < css::sdbc::XResultSet >& xResultTwo, sal_IntPtr nIndexOne, sal_IntPtr nIndexTwo ) throw( css::sdbc::SQLException, css::uno::RuntimeException ); void PropertyChanged( const css::beans::PropertyChangeEvent& rEvt ); diff --git a/ucb/source/ucp/cmis/cmis_content.cxx b/ucb/source/ucp/cmis/cmis_content.cxx index 0fe69368d696..7ea714f12175 100644 --- a/ucb/source/ucp/cmis/cmis_content.cxx +++ b/ucb/source/ucp/cmis/cmis_content.cxx @@ -88,7 +88,7 @@ namespace return unoTime; } - uno::Any lcl_cmisPropertyToUno( libcmis::PropertyPtr pProperty ) + uno::Any lcl_cmisPropertyToUno( const libcmis::PropertyPtr& pProperty ) { uno::Any aValue; switch ( pProperty->getPropertyType( )->getType( ) ) @@ -1393,8 +1393,8 @@ namespace cmis const int TRANSFER_BUFFER_SIZE = 65536; void Content::copyData( - uno::Reference< io::XInputStream > xIn, - uno::Reference< io::XOutputStream > xOut ) + const uno::Reference< io::XInputStream >& xIn, + const uno::Reference< io::XOutputStream >& xOut ) { uno::Sequence< sal_Int8 > theData( TRANSFER_BUFFER_SIZE ); @@ -1498,7 +1498,7 @@ namespace cmis return aRet; } - bool Content::feedSink( uno::Reference< uno::XInterface> xSink, + bool Content::feedSink( const uno::Reference< uno::XInterface>& xSink, const uno::Reference< ucb::XCommandEnvironment >& xEnv ) { if ( !xSink.is() ) diff --git a/ucb/source/ucp/cmis/cmis_content.hxx b/ucb/source/ucp/cmis/cmis_content.hxx index f835a963524f..0252ed59de29 100644 --- a/ucb/source/ucp/cmis/cmis_content.hxx +++ b/ucb/source/ucp/cmis/cmis_content.hxx @@ -109,8 +109,8 @@ private: OUString cancelCheckOut( const css::uno::Reference< css::ucb::XCommandEnvironment > & xEnv ) throw( css::uno::Exception ); - static void copyData( css::uno::Reference< css::io::XInputStream > xIn, - css::uno::Reference< css::io::XOutputStream > xOut ); + static void copyData( const css::uno::Reference< css::io::XInputStream >& xIn, + const css::uno::Reference< css::io::XOutputStream >& xOut ); css::uno::Sequence< css::uno::Any > setPropertyValues( const css::uno::Sequence< css::beans::PropertyValue >& rValues, @@ -121,7 +121,7 @@ private: throw(css::uno::Exception, std::exception); - bool feedSink( css::uno::Reference< css::uno::XInterface> aSink, + bool feedSink( const css::uno::Reference< css::uno::XInterface>& aSink, const css::uno::Reference< css::ucb::XCommandEnvironment >& xEnv ); public: diff --git a/ucb/source/ucp/gio/gio_content.cxx b/ucb/source/ucp/gio/gio_content.cxx index 5073b9da5d7e..4152428caeb9 100644 --- a/ucb/source/ucp/gio/gio_content.cxx +++ b/ucb/source/ucp/gio/gio_content.cxx @@ -811,8 +811,8 @@ bool Content::doSetFileInfo(GFileInfo *pNewInfo) const int TRANSFER_BUFFER_SIZE = 65536; -void Content::copyData( uno::Reference< io::XInputStream > xIn, - uno::Reference< io::XOutputStream > xOut ) +void Content::copyData( const uno::Reference< io::XInputStream >& xIn, + const uno::Reference< io::XOutputStream >& xOut ) { uno::Sequence< sal_Int8 > theData( TRANSFER_BUFFER_SIZE ); @@ -824,7 +824,7 @@ void Content::copyData( uno::Reference< io::XInputStream > xIn, xOut->closeOutput(); } -bool Content::feedSink( uno::Reference< uno::XInterface > xSink, +bool Content::feedSink( const uno::Reference< uno::XInterface >& xSink, const uno::Reference< ucb::XCommandEnvironment >& /*xEnv*/ ) { if ( !xSink.is() ) diff --git a/ucb/source/ucp/gio/gio_content.hxx b/ucb/source/ucp/gio/gio_content.hxx index 6bb53cb6abb4..84b8534dc634 100644 --- a/ucb/source/ucp/gio/gio_content.hxx +++ b/ucb/source/ucp/gio/gio_content.hxx @@ -101,8 +101,8 @@ private: void destroy( bool bDeletePhysical ) throw( css::uno::Exception, std::exception ); - static void copyData( css::uno::Reference< css::io::XInputStream > xIn, - css::uno::Reference< css::io::XOutputStream > xOut ); + static void copyData( const css::uno::Reference< css::io::XInputStream >& xIn, + const css::uno::Reference< css::io::XOutputStream >& xOut ); css::uno::Sequence< css::uno::Any > setPropertyValues( const css::uno::Sequence< @@ -110,7 +110,7 @@ private: const css::uno::Reference< css::ucb::XCommandEnvironment >& xEnv ); - bool feedSink( css::uno::Reference< css::uno::XInterface> aSink, + bool feedSink( const css::uno::Reference< css::uno::XInterface>& aSink, const css::uno::Reference< css::ucb::XCommandEnvironment >& xEnv ); bool exchangeIdentity(const css::uno::Reference< css::ucb::XContentIdentifier >& xNewId); |