diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-09-18 14:15:59 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-09-19 11:42:47 +0200 |
commit | 82572caae4a282cdf79456b977508ca71507c584 (patch) | |
tree | befc8478f8cd9bf7e7c9a87a776b063a9ed4b718 /ucb | |
parent | 71ef762f21ada8c25aad2183065478171e985e8c (diff) |
improve and enable loplugin:fragiledestructor
Where the problem was benign and the class was not extended, I marked
the class as final.
Where the problem was benign and the class was extended, I marked the
relevant callee methods as final.
Other cases were excluded in the plugin.
Change-Id: Idb762fb2206af4e8b534aa35ff77f8368c7909bc
Reviewed-on: https://gerrit.libreoffice.org/79089
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'ucb')
-rw-r--r-- | ucb/source/ucp/file/filinpstr.hxx | 2 | ||||
-rw-r--r-- | ucb/source/ucp/gio/gio_inputstream.hxx | 2 | ||||
-rw-r--r-- | ucb/source/ucp/gio/gio_outputstream.hxx | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/ucb/source/ucp/file/filinpstr.hxx b/ucb/source/ucp/file/filinpstr.hxx index 92cfb12f134a..37354f258b08 100644 --- a/ucb/source/ucp/file/filinpstr.hxx +++ b/ucb/source/ucp/file/filinpstr.hxx @@ -34,7 +34,7 @@ namespace fileaccess { class TaskManager; - class XInputStream_impl + class XInputStream_impl final : public cppu::OWeakObject, public css::lang::XTypeProvider, public css::io::XInputStream, diff --git a/ucb/source/ucp/gio/gio_inputstream.hxx b/ucb/source/ucp/gio/gio_inputstream.hxx index 2ee4eb03e961..2a808ade71d5 100644 --- a/ucb/source/ucp/gio/gio_inputstream.hxx +++ b/ucb/source/ucp/gio/gio_inputstream.hxx @@ -31,7 +31,7 @@ namespace gio { -class InputStream: public cppu::WeakImplHelper<css::io::XInputStream> +class InputStream final : public cppu::WeakImplHelper<css::io::XInputStream> { private: GFileInputStream * const mpStream; diff --git a/ucb/source/ucp/gio/gio_outputstream.hxx b/ucb/source/ucp/gio/gio_outputstream.hxx index 689cb38dd068..705eb68955c8 100644 --- a/ucb/source/ucp/gio/gio_outputstream.hxx +++ b/ucb/source/ucp/gio/gio_outputstream.hxx @@ -33,7 +33,7 @@ namespace gio { -class OutputStream : +class OutputStream final : public css::io::XOutputStream, public Seekable { |