diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2023-04-12 10:50:46 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2023-04-14 07:54:28 +0200 |
| commit | bc2101646bc6e63944c42500af5a15134b9b2d17 (patch) | |
| tree | ca1da50da2e3e76eef650a1ae3956c16e0a19f33 /ucb | |
| parent | ad97694737c99889bc0eb21efccb83768d510361 (diff) | |
loplugin:stringviewparam improvements
improve the check by checking for methods that exclude
using string_view, rather than checking for methods that
__can__ use string_view, which leads to exposing
some holes in our o3tl/string_view.hxx coverage.
Change-Id: Ic9dd60441c671f502692f9cd2a1bb67301c4b960
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150277
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'ucb')
| -rw-r--r-- | ucb/source/ucp/webdav-curl/ContentProperties.cxx | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/ucb/source/ucp/webdav-curl/ContentProperties.cxx b/ucb/source/ucp/webdav-curl/ContentProperties.cxx index d78d138ab215..d76c03d7589d 100644 --- a/ucb/source/ucp/webdav-curl/ContentProperties.cxx +++ b/ucb/source/ucp/webdav-curl/ContentProperties.cxx @@ -25,6 +25,7 @@ #include "DateTimeHelper.hxx" #include "webdavprovider.hxx" #include "ContentProperties.hxx" +#include <o3tl/string_view.hxx> using namespace com::sun::star; using namespace http_dav_ucp; @@ -490,8 +491,7 @@ void ContentProperties::addProperty( const OUString & rName, namespace { - bool isCachable( OUString const & rName, - bool isCaseSensitive ) + bool isCachable( std::u16string_view rName, bool isCaseSensitive ) { const OUString aNonCachableProps [] = { @@ -518,11 +518,11 @@ namespace { if ( isCaseSensitive ) { - if ( rName.equals( aNonCachableProps[ n ] ) ) + if ( rName == aNonCachableProps[ n ] ) return false; } else - if ( rName.equalsIgnoreAsciiCase( aNonCachableProps[ n ] ) ) + if ( o3tl::equalsIgnoreAsciiCase( rName, aNonCachableProps[ n ] ) ) return false; } return true; |