summaryrefslogtreecommitdiff
path: root/udkapi
diff options
context:
space:
mode:
authorJustin Luth <justin.luth@collabora.com>2018-08-27 21:22:01 +0300
committerMiklos Vajna <vmiklos@collabora.co.uk>2018-09-14 09:07:36 +0200
commit65c43d97f3f03e944c6bc35eb44a1ebcde31094e (patch)
treee850e64e182f4b8bc84f87fa7e8eca23a367d04f /udkapi
parent515f97e3dd279ca8487f6f6038045511f0e1db51 (diff)
tdf#82177 docx export: eliminate invalid tbl insideV/H borders
Inherited from OOo, these insideV/H borders incorrectly assume that every inside border will match the bottom/right border of cell A1. For the most part this error is harmless since every cell specifies every border anyway (that doesn't match a table-style default). The only time it is visible is when insideV/H specifies a border, but none is set on the cell. The problem is that these pseudo-defaults are not passed to the cellborders function as defaults, so cells have no idea whether they need to override these values or not. Since the implementation is completely flawed and unnecessary, simply eliminate it. (TODO: In fact, the entire tblBorders output is flawed, as demonstrated by the outside borders in the unit test.) One unit test is removed since insideV/H is no longer being written (this was just a "lets specify what we see being written out" test, not one concerned specifically with insideV/H. Not enforcing the absence of insideV/H because theoretically someone could legitimately add zero-width borders to the table borders and still be valid. The ordering of the borders test was moved from a table borders test (no longer created) to a styles border (which is still valid - a grabbag dump.) Change-Id: Ie6786a66fe88d2c7e3bdcff8fda3b4f77cb988d7 Reviewed-on: https://gerrit.libreoffice.org/59675 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
Diffstat (limited to 'udkapi')
0 files changed, 0 insertions, 0 deletions