diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-11-28 15:13:42 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-11-29 07:17:37 +0100 |
| commit | 21de55596c0fdc2be736c6d0369bd9d3783020be (patch) | |
| tree | 07d0f0cd54690e54405fe574c572cb2be74a3336 /unodevtools/source | |
| parent | da9fb5d6d9ebf9363981c370ce937d8848989fcb (diff) | |
remove unnecessary "if (!empty()" checks before loops
found with
git grep -n -A4 'if.*!.*empty' | grep -B3 -P
'(\bfor)|(\bwhile)|(\bdo)'
Change-Id: I582235b7cf977a0f9fb4099eb306fdb4a07b5334
Reviewed-on: https://gerrit.libreoffice.org/64169
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'unodevtools/source')
| -rw-r--r-- | unodevtools/source/skeletonmaker/cppcompskeleton.cxx | 20 |
1 files changed, 9 insertions, 11 deletions
diff --git a/unodevtools/source/skeletonmaker/cppcompskeleton.cxx b/unodevtools/source/skeletonmaker/cppcompskeleton.cxx index 3cf2a236f08b..097115d94879 100644 --- a/unodevtools/source/skeletonmaker/cppcompskeleton.cxx +++ b/unodevtools/source/skeletonmaker/cppcompskeleton.cxx @@ -569,18 +569,16 @@ static void generateMemberInitialization(std::ostream& o, rtl::Reference< TypeManager > const & manager, AttributeInfo const & members) { - if (!members.empty()) { - for (const auto& rMember : members) + for (const auto& rMember : members) + { + sal_Int32 rank; + if ((manager->decompose(rMember.type, true, nullptr, &rank, nullptr, nullptr) + <= codemaker::UnoType::Sort::Char) + && rank == 0) { - sal_Int32 rank; - if ((manager->decompose(rMember.type, true, nullptr, &rank, nullptr, nullptr) - <= codemaker::UnoType::Sort::Char) - && rank == 0) - { - o << ",\n m_" << rMember.name << "("; - printType(o, options, manager, rMember.type, 16, true); - o << ")"; - } + o << ",\n m_" << rMember.name << "("; + printType(o, options, manager, rMember.type, 16, true); + o << ")"; } } } |