diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-09-07 16:07:31 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-09-08 08:45:51 +0200 |
commit | 09978dd1fc18ce1ae707bc9e4ea1d2745ff07b61 (patch) | |
tree | 7d532a53e81dbbf7b070e9edb223c2935b61e783 /unoidl | |
parent | 7764ae70b04058a64a3999529e98d1115ba59d1c (diff) |
clang-tidy bugprone-unused-return-value
In
OStorage::openEncryptedStream
the lines were marked with a TODO until the TODO comment was removed in
commit 8083b46285fefc4af751e1b00d20b40bea196ea8
Date: Tue Jun 16 16:15:54 2009 +0000
CWS-TOOLING: integrate CWS fwk103
Since no-one has "fixed" this intended functionality by now,
I just removed it.
The lines in unoidl/ were introduced by
commit 12353c73868d26690aa4ac008ef5e9f2db8bc12c
Date: Fri Mar 1 23:23:50 2013 +0100
WIP: Experimental new binary type.rdb format
I assume that not throwing these was just an oversight.
Change-Id: I26fbcce267f2cc1154a30b8259176f59611dfbd8
Reviewed-on: https://gerrit.libreoffice.org/60161
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'unoidl')
-rw-r--r-- | unoidl/source/legacyprovider.cxx | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/unoidl/source/legacyprovider.cxx b/unoidl/source/legacyprovider.cxx index eb9462c733f2..b39c08d806d8 100644 --- a/unoidl/source/legacyprovider.cxx +++ b/unoidl/source/legacyprovider.cxx @@ -377,7 +377,7 @@ rtl::Reference< Entity > readEntity( base = reader.getSuperTypeName(0).replace('/', '.'); break; default: - FileFormatException( + throw FileFormatException( key.getRegistryName(), ("legacy format: unexpected number " + OUString::number(reader.getSuperTypeCount()) @@ -397,7 +397,7 @@ rtl::Reference< Entity > readEntity( translateAnnotations(reader.getDocumentation())); } else { if (reader.getSuperTypeCount() != 0) { - FileFormatException( + throw FileFormatException( key.getRegistryName(), ("legacy format: unexpected number " + OUString::number(reader.getSuperTypeCount()) @@ -432,7 +432,7 @@ rtl::Reference< Entity > readEntity( for (sal_uInt16 j = 0; j != n; ++j) { RTConstValue v(reader.getFieldValue(j)); if (v.m_type != RT_TYPE_INT32) { - FileFormatException( + throw FileFormatException( key.getRegistryName(), ("legacy format: unexpected type " + OUString::number(v.m_type) + " of value of field " |