diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2019-10-02 13:58:09 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2019-10-02 15:24:39 +0200 |
| commit | 2c1a55641b48380738ed58d3f24aa1f062da92db (patch) | |
| tree | ebd1310f34cbeb12fbebf454e3381237c367433e /unotest | |
| parent | 094d8dd4615c1a5a5e8d1e8abf672d9b8f235eb9 (diff) | |
WTF "WTF 255 return value?"
0e68bac85293e2d60fa6db3e46de8b74ab5d502b "set up python unit test
infrastructure" had introduced unotest/source/python/org/libreoffice/unotest.py
with the comment and commented-out code. It claims it has extraced "boostraping
code from convwatch.py to unotest.py", but I can't find a trace in the git
history of a prior incarnation of that comment and commented-out code. It is
unclear what problem exactly the commenting-out of the check was supposed to
address. So put the check in place and see what, if anything, breaks.
(The commented-out return appears to be truly unnecessary, and has been removed
completely.)
Change-Id: Ie2108d70fbe076cd0832bd23bfb29fc60eedffef
Reviewed-on: https://gerrit.libreoffice.org/80029
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'unotest')
| -rw-r--r-- | unotest/source/python/org/libreoffice/unotest.py | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/unotest/source/python/org/libreoffice/unotest.py b/unotest/source/python/org/libreoffice/unotest.py index 804ddafc5518..f4818bdcfdde 100644 --- a/unotest/source/python/org/libreoffice/unotest.py +++ b/unotest/source/python/org/libreoffice/unotest.py @@ -142,10 +142,8 @@ class OfficeConnection(object): self.xContext = None self.socket = None self.soffice = None -# WTF 255 return value? -# if ret != 0: -# raise Exception("Exit status indicates failure: " + str(ret)) -# return ret + if ret != 0: + raise Exception("Exit status indicates failure: " + str(ret)) def getContext(self): return self.xContext |