diff options
author | Caolán McNamara <caolanm@redhat.com> | 2015-05-25 15:28:47 +0100 |
---|---|---|
committer | Caolán McNamara <caolanm@redhat.com> | 2015-05-26 09:57:21 +0100 |
commit | 6c9dfa8ab7cc25d6cc3ce988803118b5d56ea30b (patch) | |
tree | 83b683bb177d643385618e1f46642d014332a59d /unotools | |
parent | ecdbd313838093055c66614d7e5793aacae7c5bd (diff) |
cppcheck: noExplicitConstructor
Change-Id: If947733a205e8ece1845079be95cbc2d6cbd5029
Diffstat (limited to 'unotools')
-rw-r--r-- | unotools/source/config/configitem.cxx | 16 | ||||
-rw-r--r-- | unotools/source/config/configvaluecontainer.cxx | 2 | ||||
-rw-r--r-- | unotools/source/config/fltrcfg.cxx | 6 | ||||
-rw-r--r-- | unotools/source/config/useroptions.cxx | 2 | ||||
-rw-r--r-- | unotools/source/config/viewoptions.cxx | 2 | ||||
-rw-r--r-- | unotools/source/misc/closeveto.cxx | 2 | ||||
-rw-r--r-- | unotools/source/misc/componentresmodule.cxx | 2 | ||||
-rw-r--r-- | unotools/source/misc/fontcvt.cxx | 2 | ||||
-rw-r--r-- | unotools/source/misc/sharedunocomponent.cxx | 2 | ||||
-rw-r--r-- | unotools/source/ucbhelper/XTempFile.hxx | 2 | ||||
-rw-r--r-- | unotools/source/ucbhelper/ucblockbytes.cxx | 24 |
11 files changed, 32 insertions, 30 deletions
diff --git a/unotools/source/config/configitem.cxx b/unotools/source/config/configitem.cxx index 0d055ecf53fa..e05d960f6539 100644 --- a/unotools/source/config/configitem.cxx +++ b/unotools/source/config/configitem.cxx @@ -100,14 +100,16 @@ class ValueCounter_Impl { sal_Int16& rCnt; public: - ValueCounter_Impl(sal_Int16& rCounter): - rCnt(rCounter) - {rCnt++;} + explicit ValueCounter_Impl(sal_Int16& rCounter) + : rCnt(rCounter) + { + rCnt++; + } ~ValueCounter_Impl() - { - OSL_ENSURE(rCnt>0, "RefCount < 0 ??"); - rCnt--; - } + { + OSL_ENSURE(rCnt>0, "RefCount < 0 ??"); + rCnt--; + } }; ConfigChangeListener_Impl::ConfigChangeListener_Impl( diff --git a/unotools/source/config/configvaluecontainer.cxx b/unotools/source/config/configvaluecontainer.cxx index 7121e066033a..6ec6913eb38a 100644 --- a/unotools/source/config/configvaluecontainer.cxx +++ b/unotools/source/config/configvaluecontainer.cxx @@ -51,7 +51,7 @@ namespace utl Type aDataType; // the type object pointed to by pLocation public: - NodeValueAccessor( const OUString& _rNodePath ); + explicit NodeValueAccessor( const OUString& _rNodePath ); void bind( void* _pLocation, const Type& _rType ); diff --git a/unotools/source/config/fltrcfg.cxx b/unotools/source/config/fltrcfg.cxx index 34b0fef9b663..20baaaa99932 100644 --- a/unotools/source/config/fltrcfg.cxx +++ b/unotools/source/config/fltrcfg.cxx @@ -63,7 +63,7 @@ protected: virtual void ImplCommit() SAL_OVERRIDE; public: - SvtAppFilterOptions_Impl(const OUString& rRoot) : + explicit SvtAppFilterOptions_Impl(const OUString& rRoot) : utl::ConfigItem(rRoot), bLoadVBA(false), bSaveVBA(false) {} @@ -137,7 +137,7 @@ private: virtual void ImplCommit() SAL_OVERRIDE; public: - SvtWriterFilterOptions_Impl(const OUString& rRoot) : + explicit SvtWriterFilterOptions_Impl(const OUString& rRoot) : SvtAppFilterOptions_Impl(rRoot), bLoadExecutable(false) {} @@ -185,7 +185,7 @@ private: virtual void ImplCommit() SAL_OVERRIDE; public: - SvtCalcFilterOptions_Impl(const OUString& rRoot) : + explicit SvtCalcFilterOptions_Impl(const OUString& rRoot) : SvtAppFilterOptions_Impl(rRoot), bLoadExecutable(false) {} diff --git a/unotools/source/config/useroptions.cxx b/unotools/source/config/useroptions.cxx index 1e0efb8817e3..424b2be8a759 100644 --- a/unotools/source/config/useroptions.cxx +++ b/unotools/source/config/useroptions.cxx @@ -73,7 +73,7 @@ std::weak_ptr<SvtUserOptions::Impl> SvtUserOptions::xSharedImpl; class SvtUserOptions::ChangeListener : public cppu::WeakImplHelper1<util::XChangesListener> { public: - ChangeListener (Impl& rParent): m_rParent(rParent) { } + explicit ChangeListener (Impl& rParent): m_rParent(rParent) { } // XChangesListener virtual void SAL_CALL changesOccurred (util::ChangesEvent const& Event) throw(uno::RuntimeException, std::exception) SAL_OVERRIDE; diff --git a/unotools/source/config/viewoptions.cxx b/unotools/source/config/viewoptions.cxx index 9f078e10556e..95282f0e35c9 100644 --- a/unotools/source/config/viewoptions.cxx +++ b/unotools/source/config/viewoptions.cxx @@ -91,7 +91,7 @@ class SvtViewOptionsBase_Impl public: enum State { STATE_NONE, STATE_FALSE, STATE_TRUE }; - SvtViewOptionsBase_Impl ( const OUString& sList ); + explicit SvtViewOptionsBase_Impl(const OUString& rList); virtual ~SvtViewOptionsBase_Impl ( ); bool Exists ( const OUString& sName ); bool Delete ( const OUString& sName ); diff --git a/unotools/source/misc/closeveto.cxx b/unotools/source/misc/closeveto.cxx index b33ef2902df9..c8e68c2b06dd 100644 --- a/unotools/source/misc/closeveto.cxx +++ b/unotools/source/misc/closeveto.cxx @@ -51,7 +51,7 @@ namespace utl class CloseListener_Impl : public CloseListener_Base { public: - CloseListener_Impl(bool const bHasOwnership) + explicit CloseListener_Impl(bool const bHasOwnership) : m_bHasOwnership(bHasOwnership) { } diff --git a/unotools/source/misc/componentresmodule.cxx b/unotools/source/misc/componentresmodule.cxx index 7b75a86cdc51..74af55a443e2 100644 --- a/unotools/source/misc/componentresmodule.cxx +++ b/unotools/source/misc/componentresmodule.cxx @@ -42,7 +42,7 @@ namespace utl OComponentResModuleImpl& operator=(const OComponentResModuleImpl&) SAL_DELETED_FUNCTION; public: - OComponentResModuleImpl( const OString& _rResFilePrefix ) + explicit OComponentResModuleImpl( const OString& _rResFilePrefix ) :m_pResources( NULL ) ,m_bInitialized( false ) ,m_sResFilePrefix( _rResFilePrefix ) diff --git a/unotools/source/misc/fontcvt.cxx b/unotools/source/misc/fontcvt.cxx index a154e0529a08..c2761278b1d7 100644 --- a/unotools/source/misc/fontcvt.cxx +++ b/unotools/source/misc/fontcvt.cxx @@ -1032,7 +1032,7 @@ class StarSymbolToMSMultiFontImpl : public StarSymbolToMSMultiFont private: ::std::multimap<sal_Unicode, SymbolEntry> maMagicMap; public: - StarSymbolToMSMultiFontImpl(bool bPerfectOnly); + explicit StarSymbolToMSMultiFontImpl(bool bPerfectOnly); OUString ConvertChar(sal_Unicode &rChar) SAL_OVERRIDE; OUString ConvertString(OUString &rString, sal_Int32& rIndex) SAL_OVERRIDE; }; diff --git a/unotools/source/misc/sharedunocomponent.cxx b/unotools/source/misc/sharedunocomponent.cxx index 7d78e06aff7d..c29dce82223c 100644 --- a/unotools/source/misc/sharedunocomponent.cxx +++ b/unotools/source/misc/sharedunocomponent.cxx @@ -75,7 +75,7 @@ namespace utl CloseableComponentImpl& operator=(const CloseableComponentImpl&) SAL_DELETED_FUNCTION; public: - CloseableComponentImpl( const Reference< XInterface >& _rxComponent ); + explicit CloseableComponentImpl( const Reference< XInterface >& _rxComponent ); /** closes the component diff --git a/unotools/source/ucbhelper/XTempFile.hxx b/unotools/source/ucbhelper/XTempFile.hxx index a2ed5e511287..f8048fca0ea2 100644 --- a/unotools/source/ucbhelper/XTempFile.hxx +++ b/unotools/source/ucbhelper/XTempFile.hxx @@ -61,7 +61,7 @@ protected: void checkConnected (); public: - OTempFileService (::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext > const & context); + explicit OTempFileService (::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext > const & context); //Methods // XInterface diff --git a/unotools/source/ucbhelper/ucblockbytes.cxx b/unotools/source/ucbhelper/ucblockbytes.cxx index be090bceca9c..513757e5e09e 100644 --- a/unotools/source/ucbhelper/ucblockbytes.cxx +++ b/unotools/source/ucbhelper/ucblockbytes.cxx @@ -75,9 +75,9 @@ class UcbDataSink_Impl : public ::cppu::WeakImplHelper2< XActiveDataControl, XAc UcbLockBytesRef m_xLockBytes; public: - UcbDataSink_Impl( UcbLockBytes* pLockBytes ) - : m_xLockBytes( pLockBytes ) - {} + explicit UcbDataSink_Impl( UcbLockBytes* pLockBytes ) + : m_xLockBytes( pLockBytes ) + {} // XActiveDataControl. virtual void SAL_CALL addListener ( const Reference<XStreamListener> &/*rxListener*/) throw(RuntimeException, std::exception) SAL_OVERRIDE {} @@ -102,9 +102,9 @@ class UcbStreamer_Impl : public ::cppu::WeakImplHelper2< XActiveDataStreamer, XA UcbLockBytesRef m_xLockBytes; public: - UcbStreamer_Impl( UcbLockBytes* pLockBytes ) - : m_xLockBytes( pLockBytes ) - {} + explicit UcbStreamer_Impl( UcbLockBytes* pLockBytes ) + : m_xLockBytes( pLockBytes ) + {} // XActiveDataControl. virtual void SAL_CALL addListener ( const Reference<XStreamListener> &/*rxListener*/) throw(RuntimeException, std::exception) SAL_OVERRIDE {} @@ -150,9 +150,9 @@ class UcbPropertiesChangeListener_Impl : public ::cppu::WeakImplHelper1< XProper public: UcbLockBytesRef m_xLockBytes; - UcbPropertiesChangeListener_Impl( UcbLockBytesRef rRef ) - : m_xLockBytes( rRef ) - {} + explicit UcbPropertiesChangeListener_Impl( UcbLockBytesRef rRef ) + : m_xLockBytes( rRef ) + {} virtual void SAL_CALL disposing ( const EventObject &/*rEvent*/) throw(RuntimeException, std::exception) SAL_OVERRIDE {} virtual void SAL_CALL propertiesChange ( const Sequence<PropertyChangeEvent> &rEvent) throw(RuntimeException, std::exception) SAL_OVERRIDE; @@ -341,7 +341,7 @@ class ModeratorsActiveDataStreamer { public: - ModeratorsActiveDataStreamer(Moderator &theModerator); + explicit ModeratorsActiveDataStreamer(Moderator &theModerator); virtual ~ModeratorsActiveDataStreamer(); @@ -377,7 +377,7 @@ class ModeratorsActiveDataSink { public: - ModeratorsActiveDataSink(Moderator &theModerator); + explicit ModeratorsActiveDataSink(Moderator &theModerator); virtual ~ModeratorsActiveDataSink(); @@ -460,7 +460,7 @@ class ModeratorsInteractionHandler { public: - ModeratorsInteractionHandler(Moderator &theModerator); + explicit ModeratorsInteractionHandler(Moderator &theModerator); virtual ~ModeratorsInteractionHandler(); |