diff options
| author | Noel Grandin <noel@peralex.com> | 2015-05-27 16:33:44 +0200 |
|---|---|---|
| committer | Noel Grandin <noel@peralex.com> | 2015-05-28 12:49:54 +0200 |
| commit | d5129a9dd68978f9eccdd4597b5b6834557c422a (patch) | |
| tree | df43250172f784f3048ce42ce1c3410d1d449c1e /unotools | |
| parent | f3331f7694e74f349375c223ce7ed84838e92d89 (diff) | |
new clang plugin: loopvartoosmall
Idea from bubli - look for loops where the index variable is of such
size that it cannot cover the range revealed by examining the length
part of the condition.
So far, I have only run the plugin up till the VCL module.
Also the plugin deliberately excludes anything more complicated than a
straightforward incrementing for loop.
Change-Id: Ifced18b01c03ea537c64168465ce0b8287a42015
Diffstat (limited to 'unotools')
| -rw-r--r-- | unotools/source/config/searchopt.cxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/unotools/source/config/searchopt.cxx b/unotools/source/config/searchopt.cxx index 3c442ab4ad53..87dc3e0ab9b4 100644 --- a/unotools/source/config/searchopt.cxx +++ b/unotools/source/config/searchopt.cxx @@ -177,7 +177,7 @@ bool SvtSearchOptions_Impl::Load() bSucc = true; const Any* pValues = aValues.getConstArray(); - for (sal_uInt16 i = 0; i < nProps; ++i) + for (sal_Int32 i = 0; i < nProps; ++i) { const Any &rVal = pValues[i]; DBG_ASSERT( rVal.hasValue(), "property value missing" ); @@ -227,7 +227,7 @@ bool SvtSearchOptions_Impl::Save() "unexpected size of index" ); if (nProps && nProps == MAX_FLAGS_OFFSET + 1) { - for (sal_uInt16 i = 0; i < nProps; ++i) + for (sal_Int32 i = 0; i < nProps; ++i) pValue[i] <<= GetFlag(i); bSucc |= PutProperties( aNames, aValues ); } |