Find places where OUString and OString are passed by value.

It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.

So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.

Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361

1 files changed, 3 insertions, 3 deletions

diff --git a/unoxml/source/events/eventdispatcher.hxx b/unoxml/source/events/eventdispatcher.hxx
index b6259f481a20..b5541bf0f8c9 100644
--- a/unoxml/source/events/eventdispatcher.hxx
+++ b/unoxml/source/events/eventdispatcher.hxx
@@ -57,20 +57,20 @@ private:
 public:
     void addListener(
         xmlNodePtr pNode,
-        OUString aType,
+        const OUString& aType,
         const Reference<com::sun::star::xml::dom::events::XEventListener>& aListener,
         sal_Bool bCapture);
 
     void removeListener(
         xmlNodePtr pNode,
-        OUString aType,
+        const OUString& aType,
         const Reference<com::sun::star::xml::dom::events::XEventListener>& aListener,
         sal_Bool bCapture);
 
     static void callListeners(
         TypeListenerMap const& rTMap,
         xmlNodePtr const pNode,
-        OUString aType,
+        const OUString& aType,
         const Reference< XEvent >& xEvent);
 
     bool dispatchEvent(