diff options
| author | Michael Stahl <mst@openoffice.org> | 2011-02-10 16:45:03 +0100 |
|---|---|---|
| committer | Michael Stahl <mst@openoffice.org> | 2011-02-10 16:45:03 +0100 |
| commit | 141773454451569127d388a1f3fd1fdc65f5554a (patch) | |
| tree | 517a18f27d1d630a865aeaebad9c9a4e0846a182 /unoxml/source/xpath | |
| parent | 83588ab3b791910e6a55cc70a45cbb47452011b2 (diff) | |
xmlfix3: unoxml: fix various bugs uncovered by complex test:
CAttr::getSpecified() should return true.
CAttr::getValue() and CElement::setAttributeNode() could crash if no children.
CAttributesMap::*NS() methods ignored namespaceURI parameter.
CDATASection::getNodeValue() forwarded to wrong base class.
CDocument needs to override cloneNode().
CDocument::importNode(), CDocumentBuilder::parseURI() deref null argument.
CElement::getAttributes() should return an empty map.
CElementList could be created for null element.
CNode::insertBefore() did not set parent/children pointers.
CNode::setPrefix() should only work on element/attribute.
CXPathAPI had inverted check for null argument (xmlfix3 regression).
Diffstat (limited to 'unoxml/source/xpath')
| -rw-r--r-- | unoxml/source/xpath/xpathapi.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/unoxml/source/xpath/xpathapi.cxx b/unoxml/source/xpath/xpathapi.cxx index d2dc86570ab9..00d13be6348c 100644 --- a/unoxml/source/xpath/xpathapi.cxx +++ b/unoxml/source/xpath/xpathapi.cxx @@ -154,7 +154,7 @@ namespace XPath nsmap_t & rNamespaces, Reference< XNode > const& xNamespaceNode) { DOM::CNode *const pCNode(DOM::CNode::GetImplementation(xNamespaceNode)); - if (pCNode) { throw RuntimeException(); } + if (!pCNode) { throw RuntimeException(); } ::osl::MutexGuard const g(pCNode->GetOwnerDocument().GetMutex()); |