Drop bogus check for escaped $

This apparently wanted to check whether the $ starting a potential pattern
occurrence was escaped by a preceding $.  However:

* The check itself was broken, erratically looking into sPattern instead of
_inout_rFileURL for the $.

* The check was bogus, as it would have misinterpreted e.g. "$$$(loggername)".

* The resulting string is documented (in
officecfg/registry/schema/org/openoffice/Office/Logging.xcs) to be passed
through css.util.PathSubstitution.  However, neither the PathSubstitution
service's documentation (in offapi/com/sun/star/util/PathSubstitution.idl) nor
its implementation (SubstitutePathVariables::impl_substituteVariable in
framework/source/services/substitutepathvars.cxx) appear to support esacping
$ with a preceding $.  So it looks more reasonable to remove the check
completely here.

Change-Id: I445493d444904cd54f166adcbf870a918d1f9982

0 files changed, 0 insertions, 0 deletions