summaryrefslogtreecommitdiff
path: root/uui/Module_uui.mk
diff options
context:
space:
mode:
authorTor Lillqvist <tml@collabora.com>2021-01-15 15:32:58 +0200
committerTor Lillqvist <tml@collabora.com>2021-01-15 15:07:29 +0100
commitb4f6a6c143567187c6d0f374b2b9f853ecc63af0 (patch)
treea7b58b9e6a05333ae060006531343dc991d9ee15 /uui/Module_uui.mk
parent022f61e6bd876fbcbcefd63708bf4c7ee5063f3a (diff)
Fix handling of the OBJECTDESCRIPTOR clipboard (pasteboard) type on iOS
This should fix https://github.com/CollaboraOnline/online/issues/849 This is based on the corresponding fix for macOS. Much of our clipboard code for iOS is based on that for macOS. We need the pasteboard to have the OBJECTDESCRIPTOR type as a MIME type that includes the typename attribute, because the code in sc checks for that when it decides whether it is a proper OBJECTDESCRIPTOR. Simplify the data in the flavorMap array. No need to duplicate the same MIME type string as both the pasteboard type and MIME type, for those cases where the MIME type is used diretly as pasteboard type. We also know that for those types, the MIME type might have additional parameters, so be more lenient in checking. With this change, and my recent change to sot, this now works: Start the Collabora Office app. Open a spreadsheet. Select a cell range. (It can include formulas.) Copy. Close the spreadsheet document. (Killing the app process is not necessary, as no in-process clipboard is kept on iOS, but to make sure you are really accessing the system pasteboard and not some in-process cache, feel free to kill the process. After that, start Collabora Office again.) Open a spreadsheet. Paste. You get the very same cells that you pasted as such (with relative cell addresses in formulas properly adjusted, as expected). Previously, it would paste an image of the copied cell range, which is fairly pointless. There is still lots of opportunity for cleanup in the clipboard code for macOS and iOS. Change-Id: I4a385d52bbaafcd2ab8cb18e8f613c5efa592d11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109368 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
Diffstat (limited to 'uui/Module_uui.mk')
0 files changed, 0 insertions, 0 deletions