diff options
| author | Noel Grandin <noelgrandin@gmail.com> | 2023-09-30 20:47:46 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2023-10-03 10:12:41 +0200 |
| commit | d9e322d60f65ff20631dab87baa5a2c7c71daaa2 (patch) | |
| tree | d481e5a4728363b3866b5b5f6dbe64a2780b04a6 /uui | |
| parent | 64fc701388d1dcf8ae36ba2cc73eb5416a7c3374 (diff) | |
replace ErrorInfo with simpler mechanism
Instead of returning ErrCode class everywhere, return a new
class ErrrCodeMsg, which combines an ErrCode with the other
parameters that are used to control the error reporting.
I do not change everything that uses ErrCode here, I started
from SfxBaseController/SfxMedium and worked outwards.
This change serves two purposes
(1) Replace the extremely whacky ErrorInfo mechanism we were
using to smuggle information into the error handler reporting
mechanism with a very straightforward approach of just combining it
into the error class.
(2) Allow us to capture the source location that produced the error,
which makes debugging the source of a problem soooo much easier.
Change-Id: I978b8f00c9851b41a216c7ebdef2ef94251d5519
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157440
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'uui')
| -rw-r--r-- | uui/source/iahndl.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/uui/source/iahndl.cxx b/uui/source/iahndl.cxx index e4aedbfc72dd..3eed5811f202 100644 --- a/uui/source/iahndl.cxx +++ b/uui/source/iahndl.cxx @@ -1225,7 +1225,7 @@ bool ErrorResource::getString(ErrCode nErrorCode, OUString &rString) const { for (const std::pair<TranslateId, ErrCode>* pStringArray = m_pStringArray; pStringArray->first; ++pStringArray) { - if (nErrorCode.StripWarningAndDynamic() == pStringArray->second.StripWarningAndDynamic()) + if (nErrorCode.StripWarning() == pStringArray->second.StripWarning()) { rString = Translate::get(pStringArray->first, m_rResLocale); return true; |