tdf#151548 vba FormFields: Add basic word::XFormField support

Squashed commit including followups from various people.

Unit tests will come in the following commits that represent
actual FormFields that have content/results.

This lays the foundation for adding
Checkboxes, Textinputs, and Dropdowns.

Change-Id: If85ae25f881198d5a0699b3350a7eb20b1735c45
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142507
Reviewed-by: Justin Luth <jluth@mail.com>
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>

private field 'm_xModel' is not used [-Werror,-Wunused-private-field]

ever since
commit 2a26f136a36791c06caa895d5a25f4633fd10651
Author: Justin Luth <justin.luth@collabora.com>
Date:   Wed Nov 9 17:02:03 2022 -0500
tdf#151548 vba FormFields: Add basic word::XFormField support

Plus, this code is std::move'ing a value into a "&" field, which is
very wrong

Change-Id: Ia8bbf6e0eaa524ca0f5bbf7624f4b9555920f993
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142545
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>

Fix typos

Change-Id: Id924e4747d6a3d81b69da28910c8e096565b9b68
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142538
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

Clean up some seeming copy/paste mistakes

...all introduced with 2a26f136a36791c06caa895d5a25f4633fd10651 "tdf#151548 vba
FormFields: Add basic word::XFormField support":

For the SwVbaFormField ctor, std::move of a const lvalue has no effect here.
(And I just don't bother applying the move-from-pass-by-value-param optimization
here.)

For FormFieldCollectionHelper, consistently make the data members non-const (a
const css::uno::Reference wouldn't make that much sense anyway, as it doesn't
transitively apply const'ness also to the referenced object) and non-reference,
and make the FormFieldCollectionHelper params non-const (and non-reference) to
make the move-from-pass-by-value-param optimization actually work here.

(I came across this code with an upcoming loplugin:constmove that flags
suspicious uses of std::move involving const-qualified types.)

Change-Id: Ib41d4671b33871eddff41bc20ea38de02d616046
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142568
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142644
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Justin Luth <jluth@mail.com>

0 files changed, 0 insertions, 0 deletions