diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2014-10-15 15:58:56 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2014-10-15 15:58:56 +0200 |
| commit | ad9498f8b888f7851a8612b8d654a2bc89005925 (patch) | |
| tree | ff7e98ce301121fdddf44f2fc8cb42bd2b1fac4f /vbahelper/source/msforms | |
| parent | eea16cb3e65a4308caddb7618d31a76ca259dbb1 (diff) | |
More -Werror,-Wunused-private-field
...detected with a modified trunk Clang with
> Index: lib/Sema/SemaDeclCXX.cpp
> ===================================================================
> --- lib/Sema/SemaDeclCXX.cpp (revision 219190)
> +++ lib/Sema/SemaDeclCXX.cpp (working copy)
> @@ -1917,9 +1917,10 @@
> const Type *T = FD.getType()->getBaseElementTypeUnsafe();
> // FIXME: Destruction of ObjC lifetime types has side-effects.
> if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl())
> - return !RD->isCompleteDefinition() ||
> - !RD->hasTrivialDefaultConstructor() ||
> - !RD->hasTrivialDestructor();
> + return !RD->hasAttr<WarnUnusedAttr>() &&
> + (!RD->isCompleteDefinition() ||
> + !RD->hasTrivialDefaultConstructor() ||
> + !RD->hasTrivialDestructor());
> return false;
> }
>
> @@ -3517,9 +3518,11 @@
> bool addFieldInitializer(CXXCtorInitializer *Init) {
> AllToInit.push_back(Init);
>
> +#if 0
> // Check whether this initializer makes the field "used".
> if (Init->getInit()->HasSideEffects(S.Context))
> S.UnusedPrivateFields.remove(Init->getAnyMember());
> +#endif
>
> return false;
> }
to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about
initializations with side effects (cf.
<http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html>
"-Wunused-private-field distracted by side effects").
Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
Diffstat (limited to 'vbahelper/source/msforms')
| -rw-r--r-- | vbahelper/source/msforms/vbacombobox.hxx | 1 | ||||
| -rw-r--r-- | vbahelper/source/msforms/vbalistbox.hxx | 2 | ||||
| -rw-r--r-- | vbahelper/source/msforms/vbatogglebutton.hxx | 1 |
3 files changed, 0 insertions, 4 deletions
diff --git a/vbahelper/source/msforms/vbacombobox.hxx b/vbahelper/source/msforms/vbacombobox.hxx index 9d12a3e48491..10a837f173e4 100644 --- a/vbahelper/source/msforms/vbacombobox.hxx +++ b/vbahelper/source/msforms/vbacombobox.hxx @@ -36,7 +36,6 @@ class ScVbaComboBox : public ComboBoxImpl_BASE { std::unique_ptr< ListControlHelper > mpListHelper; OUString sSourceName; - OUString msDftPropName; public: ScVbaComboBox( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext, const css::uno::Reference< css::uno::XInterface >& xControl, const css::uno::Reference< css::frame::XModel >& xModel, ov::AbstractGeometryAttributes* pGeomHelper ); diff --git a/vbahelper/source/msforms/vbalistbox.hxx b/vbahelper/source/msforms/vbalistbox.hxx index ed20cdb775bf..1a6837e3743d 100644 --- a/vbahelper/source/msforms/vbalistbox.hxx +++ b/vbahelper/source/msforms/vbalistbox.hxx @@ -34,8 +34,6 @@ class ScVbaListBox : public ListBoxImpl_BASE ,public PropListener { std::unique_ptr< ListControlHelper > mpListHelper; - OUString sSourceName; - OUString msDftPropName; sal_Int16 m_nIndex; diff --git a/vbahelper/source/msforms/vbatogglebutton.hxx b/vbahelper/source/msforms/vbatogglebutton.hxx index 86edf7b16ee1..012f190845ba 100644 --- a/vbahelper/source/msforms/vbatogglebutton.hxx +++ b/vbahelper/source/msforms/vbatogglebutton.hxx @@ -28,7 +28,6 @@ typedef cppu::ImplInheritanceHelper2< ScVbaControl, ov::msforms::XToggleButton, class ScVbaToggleButton : public ToggleButtonImpl_BASE { - OUString msDftPropName; public: ScVbaToggleButton( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext, const css::uno::Reference< css::uno::XInterface >& xControl, const css::uno::Reference< css::frame::XModel >& xModel, ov::AbstractGeometryAttributes* pGeomHelper ); virtual ~ScVbaToggleButton(); |