Revert "loplugin:constfields in vbahelper"

This reverts commit cc34b5a4c2d231de3882508654f15765d29f44c9.

Change-Id: I891826d88dd4e8bc8e6896889f4c1880c798080f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90543
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

10 files changed, 15 insertions, 15 deletions

diff --git a/vbahelper/source/msforms/vbacontrol.cxx b/vbahelper/source/msforms/vbacontrol.cxx
index da1287d2e60c..8efb94de7780 100644
--- a/vbahelper/source/msforms/vbacontrol.cxx
+++ b/vbahelper/source/msforms/vbacontrol.cxx
@@ -436,8 +436,8 @@ namespace {
 
 struct PointerStyles
 {
-   long const msoPointerStyle;
-   PointerStyle const loPointStyle;
+   long msoPointerStyle;
+   PointerStyle loPointStyle;
 };
 
 }
diff --git a/vbahelper/source/msforms/vbacontrols.cxx b/vbahelper/source/msforms/vbacontrols.cxx
index c019c376c2d7..56a0b80aebe2 100644
--- a/vbahelper/source/msforms/vbacontrols.cxx
+++ b/vbahelper/source/msforms/vbacontrols.cxx
@@ -148,8 +148,8 @@ class ControlsEnumWrapper : public EnumerationHelper_BASE
     uno::Reference<container::XIndexAccess > m_xIndexAccess;
     uno::Reference<awt::XControl > m_xDlg;
     uno::Reference< frame::XModel > m_xModel;
-    double const mfOffsetX;
-    double const mfOffsetY;
+    double mfOffsetX;
+    double mfOffsetY;
     sal_Int32 nIndex;
 
 public:
diff --git a/vbahelper/source/msforms/vbacontrols.hxx b/vbahelper/source/msforms/vbacontrols.hxx
index 4f1b01c6876c..1e9d95042633 100644
--- a/vbahelper/source/msforms/vbacontrols.hxx
+++ b/vbahelper/source/msforms/vbacontrols.hxx
@@ -54,8 +54,8 @@ public:
 private:
     css::uno::Reference< css::awt::XControl > mxDialog;
     css::uno::Reference< css::frame::XModel > mxModel;
-    double const mfOffsetX;
-    double const mfOffsetY;
+    double mfOffsetX;
+    double mfOffsetY;
 };
 
 #endif // INCLUDED_VBAHELPER_SOURCE_MSFORMS_VBACONTROLS_HXX
diff --git a/vbahelper/source/msforms/vbalistcontrolhelper.cxx b/vbahelper/source/msforms/vbalistcontrolhelper.cxx
index b1601f99ec43..02a500aa2f8c 100644
--- a/vbahelper/source/msforms/vbalistcontrolhelper.cxx
+++ b/vbahelper/source/msforms/vbalistcontrolhelper.cxx
@@ -32,8 +32,8 @@ class ListPropListener : public PropListener
 {
 private:
     uno::Reference< beans::XPropertySet > m_xProps;
-    uno::Any const m_pvargIndex;
-    uno::Any const m_pvarColumn;
+    uno::Any m_pvargIndex;
+    uno::Any m_pvarColumn;
 
 public:
     ListPropListener( const uno::Reference< beans::XPropertySet >& xProps, const uno::Any& pvargIndex, const uno::Any& pvarColumn );
diff --git a/vbahelper/source/msforms/vbamultipage.cxx b/vbahelper/source/msforms/vbamultipage.cxx
index 58ca2182cda6..a23949ad9dc0 100644
--- a/vbahelper/source/msforms/vbamultipage.cxx
+++ b/vbahelper/source/msforms/vbamultipage.cxx
@@ -31,7 +31,7 @@ namespace {
 
 class PagesImpl : public cppu::WeakImplHelper< container::XIndexAccess >
 {
-    sal_Int32 const mnPages;
+    sal_Int32 mnPages;
 public:
     explicit PagesImpl( sal_Int32 nPages ) : mnPages( nPages ) {}
     virtual ::sal_Int32 SAL_CALL getCount() override { return mnPages; }
diff --git a/vbahelper/source/msforms/vbatextbox.hxx b/vbahelper/source/msforms/vbatextbox.hxx
index 65857b86b4ad..9a2b969423d2 100644
--- a/vbahelper/source/msforms/vbatextbox.hxx
+++ b/vbahelper/source/msforms/vbatextbox.hxx
@@ -30,7 +30,7 @@ typedef cppu::ImplInheritanceHelper< ScVbaControl, ov::msforms::XTextBox, css::s
 
 class ScVbaTextBox : public TextBoxImpl_BASE
 {
-    bool const mbDialog;
+    bool mbDialog;
 public:
     ScVbaTextBox( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext, const css::uno::Reference< css::uno::XInterface >& xControl, const css::uno::Reference< css::frame::XModel >& xModel, std::unique_ptr<ov::AbstractGeometryAttributes> pGeomHelper, bool bDialog = false );
    // Attributes
diff --git a/vbahelper/source/vbahelper/vbacolorformat.hxx b/vbahelper/source/vbahelper/vbacolorformat.hxx
index 888228e77610..0e94db6de7e6 100644
--- a/vbahelper/source/vbahelper/vbacolorformat.hxx
+++ b/vbahelper/source/vbahelper/vbacolorformat.hxx
@@ -94,7 +94,7 @@ class ScVbaColorFormat : public ScVbaColorFormat_BASE
 private:
     css::uno::Reference< css::beans::XPropertySet > m_xPropertySet;
     ScVbaFillFormat *m_pFillFormat;
-    sal_Int16 const m_nColorFormatType;
+    sal_Int16 m_nColorFormatType;
     sal_Int32 m_nFillFormatBackColor;
 protected:
     virtual OUString getServiceImplName() override;
diff --git a/vbahelper/source/vbahelper/vbacommandbar.hxx b/vbahelper/source/vbahelper/vbacommandbar.hxx
index b6508760625e..8aa9675adb26 100644
--- a/vbahelper/source/vbahelper/vbacommandbar.hxx
+++ b/vbahelper/source/vbahelper/vbacommandbar.hxx
@@ -31,8 +31,8 @@ class ScVbaCommandBar : public CommandBar_BASE
 private:
     VbaCommandBarHelperRef pCBarHelper;
     css::uno::Reference< css::container::XIndexAccess > m_xBarSettings;
-    OUString const    m_sResourceUrl;
-    bool const        m_bIsMenu;
+    OUString    m_sResourceUrl;
+    bool        m_bIsMenu;
 
 public:
     /// @throws css::uno::RuntimeException
diff --git a/vbahelper/source/vbahelper/vbacommandbarcontrol.hxx b/vbahelper/source/vbahelper/vbacommandbarcontrol.hxx
index 700868e9fe5a..348518b5ba2e 100644
--- a/vbahelper/source/vbahelper/vbacommandbarcontrol.hxx
+++ b/vbahelper/source/vbahelper/vbacommandbarcontrol.hxx
@@ -34,7 +34,7 @@ class ScVbaCommandBarControl : public CommandBarControl_BASE
 {
 protected:
     VbaCommandBarHelperRef pCBarHelper;
-    OUString const         m_sResourceUrl;
+    OUString               m_sResourceUrl;
     css::uno::Reference< css::container::XIndexAccess > m_xCurrentSettings;
     css::uno::Reference< css::container::XIndexAccess > m_xBarSettings;
     css::uno::Sequence< css::beans::PropertyValue >     m_aPropertyValues;
diff --git a/vbahelper/source/vbahelper/vbacommandbarcontrols.hxx b/vbahelper/source/vbahelper/vbacommandbarcontrols.hxx
index f30dc586eee7..5e86b359fa23 100644
--- a/vbahelper/source/vbahelper/vbacommandbarcontrols.hxx
+++ b/vbahelper/source/vbahelper/vbacommandbarcontrols.hxx
@@ -30,7 +30,7 @@ class ScVbaCommandBarControls : public CommandBarControls_BASE
 private:
     VbaCommandBarHelperRef                              pCBarHelper;
     css::uno::Reference< css::container::XIndexAccess > m_xBarSettings;
-    OUString const                                      m_sResourceUrl;
+    OUString                                            m_sResourceUrl;
     bool                                                m_bIsMenu;
 
     static css::uno::Sequence< css::beans::PropertyValue > CreateMenuItemData( const OUString& sCommandURL,