diff options
| author | Noel <noelgrandin@gmail.com> | 2020-11-13 14:29:59 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-11-17 09:57:35 +0100 |
| commit | 8ef6067596cf4b2c52fbce94b44bf7af9fefa643 (patch) | |
| tree | f4cca1a99ba97683b14fa6fe0f1f45f75bf855c2 /vbahelper | |
| parent | 75bada928cf08d2afc6efe52ba99b45088bc9eec (diff) | |
loplugin:stringviewparam check methods too
not just functions
Change-Id: Icca295dd159002b428b73f2c95d40725434f04d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105789
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'vbahelper')
| -rw-r--r-- | vbahelper/source/msforms/vbalistcontrolhelper.cxx | 4 | ||||
| -rw-r--r-- | vbahelper/source/msforms/vbalistcontrolhelper.hxx | 2 | ||||
| -rw-r--r-- | vbahelper/source/vbahelper/vbahelper.cxx | 6 |
3 files changed, 6 insertions, 6 deletions
diff --git a/vbahelper/source/msforms/vbalistcontrolhelper.cxx b/vbahelper/source/msforms/vbalistcontrolhelper.cxx index 58884dbf62fc..3fffbd5b1941 100644 --- a/vbahelper/source/msforms/vbalistcontrolhelper.cxx +++ b/vbahelper/source/msforms/vbalistcontrolhelper.cxx @@ -166,9 +166,9 @@ ListControlHelper::Clear( ) } void -ListControlHelper::setRowSource( const OUString& _rowsource ) +ListControlHelper::setRowSource( std::u16string_view _rowsource ) { - if ( _rowsource.isEmpty() ) + if ( _rowsource.empty() ) Clear(); } diff --git a/vbahelper/source/msforms/vbalistcontrolhelper.hxx b/vbahelper/source/msforms/vbalistcontrolhelper.hxx index dff3e1c33541..e80ba3e857cb 100644 --- a/vbahelper/source/msforms/vbalistcontrolhelper.hxx +++ b/vbahelper/source/msforms/vbalistcontrolhelper.hxx @@ -33,7 +33,7 @@ public: /// @throws css::uno::RuntimeException void removeItem( const css::uno::Any& index ); /// @throws css::uno::RuntimeException - void setRowSource( const OUString& _rowsource ); + void setRowSource( std::u16string_view _rowsource ); /// @throws css::uno::RuntimeException ::sal_Int32 getListCount(); /// @throws css::uno::RuntimeException diff --git a/vbahelper/source/vbahelper/vbahelper.cxx b/vbahelper/source/vbahelper/vbahelper.cxx index e7dafba16ffc..67a4795fffa9 100644 --- a/vbahelper/source/vbahelper/vbahelper.cxx +++ b/vbahelper/source/vbahelper/vbahelper.cxx @@ -1020,13 +1020,13 @@ void ShapeHelper::setTop(double _fTop) xShape->setPosition(aPoint); } -void DebugHelper::basicexception( const css::uno::Exception& ex, ErrCode err, const OUString& /*additionalArgument*/ ) +void DebugHelper::basicexception( const css::uno::Exception& ex, ErrCode err, std::u16string_view /*additionalArgument*/ ) { // #TODO #FIXME ( do we want to support additionalArg here ) throw css::script::BasicErrorException( ex.Message, css::uno::Reference< css::uno::XInterface >(), sal_uInt32(err), OUString() ); } -void DebugHelper::basicexception( ErrCode err, const OUString& additionalArgument ) +void DebugHelper::basicexception( ErrCode err, std::u16string_view additionalArgument ) { basicexception( css::uno::Exception(), err, additionalArgument ); } @@ -1085,7 +1085,7 @@ uno::Reference< XHelperInterface > getVBADocument( const uno::Reference< frame:: return xIf; } -uno::Reference< XHelperInterface > getUnoDocModule( const OUString& aModName, SfxObjectShell const * pShell ) +uno::Reference< XHelperInterface > getUnoDocModule( std::u16string_view aModName, SfxObjectShell const * pShell ) { uno::Reference< XHelperInterface > xIf; if ( pShell ) |