diff options
author | Khaled Hosny <khaledhosny@eglug.org> | 2013-06-18 01:26:16 +0200 |
---|---|---|
committer | Khaled Hosny <khaledhosny@eglug.org> | 2013-06-18 04:26:34 +0200 |
commit | 984dadaf69a945c8f5e0680bca4b5830b9ebc094 (patch) | |
tree | e42f2cd92599186ab91d7b9c7d009e77872c8eef /vcl/coretext | |
parent | fd7861397bb4e8dc5ad694a7f677e10fd271f0f6 (diff) |
Some notes
Change-Id: I665826017f03b123a8b80d6cf31e37d18e169d10
Diffstat (limited to 'vcl/coretext')
-rw-r--r-- | vcl/coretext/ctfonts.cxx | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/vcl/coretext/ctfonts.cxx b/vcl/coretext/ctfonts.cxx index afbd8e943bbc..81feaad4ed3e 100644 --- a/vcl/coretext/ctfonts.cxx +++ b/vcl/coretext/ctfonts.cxx @@ -138,7 +138,8 @@ void CTTextStyle::GetFontMetric( float fPixelSize, ImplFontMetricData& rMetric ) bool CTTextStyle::GetGlyphBoundRect( sal_GlyphId nGlyphId, Rectangle& rRect ) const { - CGGlyph nCGGlyph = nGlyphId & GF_IDXMASK; // NOTE: CoreText handles glyph fallback itself + CGGlyph nCGGlyph = nGlyphId & GF_IDXMASK; + // XXX: this is broken if the glyph came from fallback font CTFontRef aCTFontRef = (CTFontRef)CFDictionaryGetValue( mpStyleDict, kCTFontAttributeName ); const CTFontOrientation aFontOrientation = kCTFontDefaultOrientation; // TODO: horz/vert @@ -197,8 +198,8 @@ bool CTTextStyle::GetGlyphOutline( sal_GlyphId nGlyphId, basegfx::B2DPolyPolygon { rResult.clear(); - // TODO: GF_FONTMASK if using non-native glyph fallback CGGlyph nCGGlyph = nGlyphId & GF_IDXMASK; + // XXX: this is broken if the glyph came from fallback font CTFontRef pCTFont = (CTFontRef)CFDictionaryGetValue( mpStyleDict, kCTFontAttributeName ); CGPathRef xPath = CTFontCreatePathForGlyph( pCTFont, nCGGlyph, NULL ); |