diff options
author | Jan-Marek Glogowski <jan-marek.glogowski@extern.cib.de> | 2019-08-08 17:59:20 +0000 |
---|---|---|
committer | Jan-Marek Glogowski <glogow@fbihome.de> | 2019-08-22 14:29:03 +0200 |
commit | 3355be0616c24c5e44b71e7623c4191ed9c69074 (patch) | |
tree | 9343975454c1656c16222ac09bd0cc9e22a43dd4 /vcl/inc/qt5/Qt5Widget.hxx | |
parent | bafd4194b6ffbe4d6adfe01404196d787800dabe (diff) |
tdf#126560 Qt5 fix D'n'D key-modifier handling
The patch has still one problem: the key-modifier state isn't
reflected by the cursor, unless the user moves the mouse. There is
an upstream Qt bug, reported in 2016-09 against Qt 5.6.1! It is
supposed to be fixed in Qt 5.12, according to the bug report at
https://bugreports.qt.io/browse/QTBUG-56218, which is still open.
I thought about adding a configure test, but I couldn't imagine
any realistic way to write it. And after Michael Weghorn found the
bug is actually not fixed, as claimed in one of the comments, I
decided to drop the warning.
Change-Id: Ice8ebc4ea149282b4c1551e755efe3d4856cf782
Reviewed-on: https://gerrit.libreoffice.org/77174
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
Diffstat (limited to 'vcl/inc/qt5/Qt5Widget.hxx')
-rw-r--r-- | vcl/inc/qt5/Qt5Widget.hxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/vcl/inc/qt5/Qt5Widget.hxx b/vcl/inc/qt5/Qt5Widget.hxx index 85523951cda2..a69c86876a44 100644 --- a/vcl/inc/qt5/Qt5Widget.hxx +++ b/vcl/inc/qt5/Qt5Widget.hxx @@ -57,6 +57,7 @@ class Qt5Widget : public QWidget virtual void mousePressEvent(QMouseEvent*) override; virtual void mouseReleaseEvent(QMouseEvent*) override; virtual void dragEnterEvent(QDragEnterEvent*) override; + virtual void dragLeaveEvent(QDragLeaveEvent*) override; virtual void dragMoveEvent(QDragMoveEvent*) override; virtual void dropEvent(QDropEvent*) override; virtual void moveEvent(QMoveEvent*) override; @@ -74,7 +75,6 @@ public: Qt5Widget(Qt5Frame& rFrame, Qt::WindowFlags f = Qt::WindowFlags()); Qt5Frame& getFrame() const { return m_rFrame; } - void startDrag(sal_Int8 nSourceActions); void endExtTextInput(); static bool handleEvent(Qt5Frame&, const QWidget&, QEvent*); |