tdf#130857 vcl: Move weld::Window::{g,s}et_modal to weld::Dialog

All calls to get_modal and set_modal are done for weld::Dialog
instances, never for plain instances of/pointers to the weld::Window
base class.

Therefore, drop the methods from weld::Window and add them weld::Dialog
instead.

SalInstanceDialog was already overriding the SalInstanceWindow
implementations of both methods.

For QtInstanceWindow, these were not implemented yet, while
QtInstanceDialog already has implementations.
(If there were a real need, they could be implemented using
QWidget::isModal/QWidget::windowModality and
QWidget::setWindowModality.)

For GTK, move the GtkInstanceWindow::get_modal implementation
to GtkInstanceDialog and call gtk_window_set_modal directly
instead of GtkInstanceWindow::set_modal in
GtkInstanceDialog::set_modal.

Change-Id: I71431347f3bca9571c6fd4b7cf995bb79fb5b11d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176252
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins

1 files changed, 0 insertions, 4 deletions

diff --git a/vcl/inc/salvtables.hxx b/vcl/inc/salvtables.hxx
index f7e577ab7808..b42a3f71ebc2 100644
--- a/vcl/inc/salvtables.hxx
+++ b/vcl/inc/salvtables.hxx
@@ -475,10 +475,6 @@ public:
 
     virtual void resize_to_request() override;
 
-    virtual void set_modal(bool bModal) override;
-
-    virtual bool get_modal() const override;
-
     virtual void window_move(int x, int y) override;
 
     virtual Size get_size() const override;