diff options
| author | Luboš Luňák <l.lunak@collabora.com> | 2020-04-30 12:23:28 +0200 |
|---|---|---|
| committer | Tomaž Vajngerl <quikee@gmail.com> | 2020-05-05 20:36:12 +0200 |
| commit | 37f472c8d0e8a195c887e34cda796cdeae550ed6 (patch) | |
| tree | 1c4fe7fd69fa508846100e06990ef3182589932a /vcl/inc/skia | |
| parent | 2cdec016bc763f5fc9dede8835c8f45139e811ca (diff) | |
fix line width in DrawPolyLine() with matrix (tdf#132498)
For backends that do the object-to-device coordinates transformation
directly, it's necessary to also convert the size of line width.
But simply multiplying it with the matrix can also rotate the line
width "vector", making it e.g. negative. So don't use just the X
coordinate, use vector length for the transformation, which is ok.
In fact it doesn't even make sense to treat width as a vector, because
a width simply is not a vector (and for this reason it's also not
actually used).
Change-Id: I1241c9cb29155df105170d568a879ebc32b11a5f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93203
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Jenkins
Diffstat (limited to 'vcl/inc/skia')
| -rw-r--r-- | vcl/inc/skia/gdiimpl.hxx | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/vcl/inc/skia/gdiimpl.hxx b/vcl/inc/skia/gdiimpl.hxx index 68652cacc790..c78845fe6ffa 100644 --- a/vcl/inc/skia/gdiimpl.hxx +++ b/vcl/inc/skia/gdiimpl.hxx @@ -103,8 +103,7 @@ public: const basegfx::B2DPolyPolygon&, double fTransparency) override; virtual bool drawPolyLine(const basegfx::B2DHomMatrix& rObjectToDevice, - const basegfx::B2DPolygon&, double fTransparency, - const basegfx::B2DVector& rLineWidths, + const basegfx::B2DPolygon&, double fTransparency, double fLineWidth, const std::vector<double>* pStroke, // MM01 basegfx::B2DLineJoin, css::drawing::LineCap, double fMiterMinimumAngle, bool bPixelSnapHairline) override; |