summaryrefslogtreecommitdiff
path: root/vcl/inc
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2020-06-06 16:50:30 +0100
committerCaolán McNamara <caolanm@redhat.com>2020-06-06 20:08:39 +0200
commit1c62824c105f5ad02f228ff9263796e9dffa9581 (patch)
treede8785d4113792a4d34b6de26ef7525fad7678ef /vcl/inc
parent821153254a25bc264ae45c52ea9f6900f9cae9d5 (diff)
focus rect in treeview doesn't match the selected area
regression from... commit 753084a3f73bb8a88412feac7aa40a2750e6e9f3 Date: Wed Dec 11 12:56:57 2019 +0200 loplugin:singlevalfields which detected that m_bIsCellFocusEnabled is always false but inadvertently make a change of -void SvImpLBox::CalcCellFocusRect( SvTreeListEntry const * pEntry, tools::Rectangle& rRect ) +void SvImpLBox::CalcCellFocusRect( tools::Rectangle& rRect ) { - if ( !(pEntry && m_bIsCellFocusEnabled) ) - return; which treats m_bIsCellFocusEnabled as always true. Always false would make CalcCellFocusRect a no-op so just remove the method to fix things. Change-Id: I46bfa122058a9e4384d2b1e2dc9e844ada22cc69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95652 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'vcl/inc')
-rw-r--r--vcl/inc/svimpbox.hxx2
1 files changed, 0 insertions, 2 deletions
diff --git a/vcl/inc/svimpbox.hxx b/vcl/inc/svimpbox.hxx
index 5d23b3f2c46b..c5a51143f141 100644
--- a/vcl/inc/svimpbox.hxx
+++ b/vcl/inc/svimpbox.hxx
@@ -189,8 +189,6 @@ private:
void UpdateContextBmpWidthMax( SvTreeListEntry const * pEntry );
void UpdateContextBmpWidthVectorFromMovedEntry( SvTreeListEntry* pEntry );
- void CalcCellFocusRect( tools::Rectangle& rRect );
-
void ExpandAll();
void CollapseTo(SvTreeListEntry* pParentToCollapse);