diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-09-18 14:15:59 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-09-19 11:42:47 +0200 |
commit | 82572caae4a282cdf79456b977508ca71507c584 (patch) | |
tree | befc8478f8cd9bf7e7c9a87a776b063a9ed4b718 /vcl/inc | |
parent | 71ef762f21ada8c25aad2183065478171e985e8c (diff) |
improve and enable loplugin:fragiledestructor
Where the problem was benign and the class was not extended, I marked
the class as final.
Where the problem was benign and the class was extended, I marked the
relevant callee methods as final.
Other cases were excluded in the plugin.
Change-Id: Idb762fb2206af4e8b534aa35ff77f8368c7909bc
Reviewed-on: https://gerrit.libreoffice.org/79089
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'vcl/inc')
-rw-r--r-- | vcl/inc/unx/gtk/gtkdata.hxx | 2 | ||||
-rw-r--r-- | vcl/inc/unx/salbmp.h | 2 | ||||
-rw-r--r-- | vcl/inc/unx/salframe.h | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/vcl/inc/unx/gtk/gtkdata.hxx b/vcl/inc/unx/gtk/gtkdata.hxx index 2475b20a28d4..f1750b7dc3a6 100644 --- a/vcl/inc/unx/gtk/gtkdata.hxx +++ b/vcl/inc/unx/gtk/gtkdata.hxx @@ -82,7 +82,7 @@ inline void widget_set_can_default(GtkWidget *widget, gboolean can_default) #endif } -class GtkSalTimer : public SalTimer +class GtkSalTimer final : public SalTimer { struct SalGtkTimeoutSource *m_pTimeout; public: diff --git a/vcl/inc/unx/salbmp.h b/vcl/inc/unx/salbmp.h index f889d44349f1..72283421d224 100644 --- a/vcl/inc/unx/salbmp.h +++ b/vcl/inc/unx/salbmp.h @@ -34,7 +34,7 @@ class ImplSalDDB; class ImplSalBitmapCache; -class VCLPLUG_GEN_PUBLIC X11SalBitmap : public SalBitmap +class VCLPLUG_GEN_PUBLIC X11SalBitmap final : public SalBitmap { private: diff --git a/vcl/inc/unx/salframe.h b/vcl/inc/unx/salframe.h index 7a67f92db49d..a913fc6165b0 100644 --- a/vcl/inc/unx/salframe.h +++ b/vcl/inc/unx/salframe.h @@ -58,7 +58,7 @@ enum class WMWindowType Dock }; -class VCLPLUG_GEN_PUBLIC X11SalFrame : public SalFrame, public NativeWindowHandleProvider +class VCLPLUG_GEN_PUBLIC X11SalFrame final : public SalFrame, public NativeWindowHandleProvider { friend class vcl_sal::WMAdaptor; friend class vcl_sal::NetWMAdaptor; |