Introduce weld::IconView::insert_separator

Needed to eventual re-implementation of starmath's SmElementsControl
using IconView.

This required re-implementation of IconViewImpl, to layout entries
by iteration, because now it's impossible to find an entry position
just based on its index.

This coincidentally fixed some visual glitches in non-gtk IconView
implementation from commit 5813660e7bfe128ac076e592fe31de64a6863780
Author Szymon Kłos <eszkadev@gmail.com>
Date   Tue Feb 16 16:03:30 2016 +0100
icon view for RemoteFilesDialog

where any selected element could become first in row when scrolling.

SvTreeListBox::SetEntryHeight taking a SvTreeListEntry const* had to
be renamed to CalcEntryHeight, to avoid both virtual and non-virtual
overloads, additionally having different accessibility.

A TODO is implement separators in GtkInstanceIconView. I couldn't
find a GTK API for separators in IconView, so possibly a workaround
would be needed with some non-selectable narrow elements.

Change-Id: Ie8dc35d94049a1c48e4eb49697681ffbe93c17f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135112
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

1 files changed, 6 insertions, 0 deletions

diff --git a/vcl/jsdialog/jsdialogbuilder.cxx b/vcl/jsdialog/jsdialogbuilder.cxx
index 3648d33b3ebc..ab1fdf7636c0 100644
--- a/vcl/jsdialog/jsdialogbuilder.cxx
+++ b/vcl/jsdialog/jsdialogbuilder.cxx
@@ -1702,6 +1702,12 @@ void JSIconView::insert(int pos, const OUString* pStr, const OUString* pId,
     sendUpdate();
 }
 
+void JSIconView::insert_separator(int pos, const OUString* pId)
+{
+    SalInstanceIconView::insert_separator(pos, pId);
+    sendUpdate();
+}
+
 void JSIconView::clear()
 {
     SalInstanceIconView::clear();