summaryrefslogtreecommitdiff
path: root/vcl/jsdialog
diff options
context:
space:
mode:
authorMéven Car <meven.car@collabora.com>2024-01-09 15:15:23 +0100
committerAndras Timar <andras.timar@collabora.com>2024-01-16 07:59:51 +0100
commit0ffa0f103f928da3785f8b6a71d2956ba51b6989 (patch)
tree649cbb0d718fbafa964c36600c13c8f44ebf4566 /vcl/jsdialog
parent777b549242ab188eb68a8201cd0659d706f627e9 (diff)
cool#1770 sw: make Edit Sections dialog async and mark it a jsdialog
We want our dialogs to be async so they don't lock documents when opened and to allow concurrent edition. In SwEditRegionDlg, we need to make sure the reference to the SwWrtShell isn't read from 'this' after `response()`, as it is now the dialog is disposed of earlier in the async case. How to test: Create a new Writer document, insert a section, right-click inside the section, pick the 'edit section' menu item to trigger this dialog. Change-Id: Ibafca69542f13d16beef5a8fca006428cbcfe5c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161828 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161830 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
Diffstat (limited to 'vcl/jsdialog')
-rw-r--r--vcl/jsdialog/enabled.cxx1
1 files changed, 1 insertions, 0 deletions
diff --git a/vcl/jsdialog/enabled.cxx b/vcl/jsdialog/enabled.cxx
index 058880a97835..c8ed0d73efad 100644
--- a/vcl/jsdialog/enabled.cxx
+++ b/vcl/jsdialog/enabled.cxx
@@ -178,6 +178,7 @@ bool isBuilderEnabled(std::u16string_view rUIFile, bool bMobile)
|| rUIFile == u"modules/swriter/ui/contentcontrollistitemdlg.ui"
|| rUIFile == u"modules/swriter/ui/dropcapspage.ui"
|| rUIFile == u"modules/swriter/ui/dropdownfielddialog.ui"
+ || rUIFile == u"modules/swriter/ui/editsectiondialog.ui"
|| rUIFile == u"modules/swriter/ui/endnotepage.ui"
|| rUIFile == u"modules/swriter/ui/footendnotedialog.ui"
|| rUIFile == u"modules/swriter/ui/footnoteareapage.ui"