diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2023-02-06 18:14:16 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2023-02-07 10:19:32 +0000 |
| commit | 00659bcdbbb167596e6fd18e283a54819dd6fe91 (patch) | |
| tree | 65316f99002c5aa6851ee1770df557b789772f20 /vcl/qa/cppunit/bitmaprender | |
| parent | 545ddfbaa98cfeaa35c95d7db7b16cd241cedc89 (diff) | |
improve readability of VirtualDevice constructor
(a) It is not obvious what DeviceFormat::DEFAULT means
(b) There are two parameters (each with two states), but only really 2
possible overall states
So
(1) use more useful names
(2) combine the two parameters into one enum
Change-Id: Ic0595b39e032cc9e019b88326389d055b977da00
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146589
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'vcl/qa/cppunit/bitmaprender')
| -rw-r--r-- | vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx b/vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx index 06758e4ae694..dbe02d455b04 100644 --- a/vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx +++ b/vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx @@ -182,8 +182,8 @@ void BitmapRenderTest::testAlphaVirtualDevice() // TODO: This unit test is not executed for macOS unless bitmap scaling is implemented #ifndef MACOSX // Create an alpha virtual device - ScopedVclPtr<VirtualDevice> pAlphaVirtualDevice(VclPtr<VirtualDevice>::Create( - *Application::GetDefaultDevice(), DeviceFormat::DEFAULT, DeviceFormat::DEFAULT)); + ScopedVclPtr<VirtualDevice> pAlphaVirtualDevice( + VclPtr<VirtualDevice>::Create(*Application::GetDefaultDevice(), DeviceFormat::WITH_ALPHA)); // Set it up pAlphaVirtualDevice->SetOutputSizePixel(Size(4, 4)); |