diff options
| author | Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk> | 2018-07-10 23:47:36 +0200 |
|---|---|---|
| committer | Tomaž Vajngerl <quikee@gmail.com> | 2018-07-11 08:26:32 +0200 |
| commit | 28493a04f0fa63a76c096c62a3141d86edbac964 (patch) | |
| tree | e4679d6037e081503aa2f5adcfffbb3e0325d989 /vcl/qa/cppunit | |
| parent | 877362dadf34c910365490ce53b2dcf902dab8cc (diff) | |
font feat: prioritize Graphite descriptions, use UI lang., fixes
When collecting font feature description do prioritize Graphite
collected descriptions over OT. This is important for descriptions
for ssxx and cvxx only contain general description and not what
exactly they do.
When collecting for Graphite use the UI language for descriptions.
Fix gathering the descriptions with graphite to include all of
the descriptions available.
Change-Id: I6b3b92eb160fc3fd70214edf0d37095865f9c563
Reviewed-on: https://gerrit.libreoffice.org/57250
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Diffstat (limited to 'vcl/qa/cppunit')
| -rw-r--r-- | vcl/qa/cppunit/FontFeatureTest.cxx | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/vcl/qa/cppunit/FontFeatureTest.cxx b/vcl/qa/cppunit/FontFeatureTest.cxx index 879411ac5d1c..6944c7c5b6b0 100644 --- a/vcl/qa/cppunit/FontFeatureTest.cxx +++ b/vcl/qa/cppunit/FontFeatureTest.cxx @@ -102,16 +102,21 @@ void FontFeatureTest::testGetFontFeatures() CPPUNIT_ASSERT_EQUAL(vcl::font::FeatureParameterType::ENUM, rFracFeatureDefinition.getType()); - CPPUNIT_ASSERT_EQUAL(size_t(2), rFracFeatureDefinition.getEnumParameters().size()); + CPPUNIT_ASSERT_EQUAL(size_t(3), rFracFeatureDefinition.getEnumParameters().size()); vcl::font::FeatureParameter const& rParameter1 = rFracFeatureDefinition.getEnumParameters()[0]; - CPPUNIT_ASSERT_EQUAL(sal_uInt32(1), rParameter1.getCode()); + CPPUNIT_ASSERT_EQUAL(sal_uInt32(0), rParameter1.getCode()); CPPUNIT_ASSERT(!rParameter1.getDescription().isEmpty()); vcl::font::FeatureParameter const& rParameter2 = rFracFeatureDefinition.getEnumParameters()[1]; - CPPUNIT_ASSERT_EQUAL(sal_uInt32(2), rParameter2.getCode()); + CPPUNIT_ASSERT_EQUAL(sal_uInt32(1), rParameter2.getCode()); + CPPUNIT_ASSERT(!rParameter2.getDescription().isEmpty()); + + vcl::font::FeatureParameter const& rParameter3 + = rFracFeatureDefinition.getEnumParameters()[2]; + CPPUNIT_ASSERT_EQUAL(sal_uInt32(2), rParameter3.getCode()); CPPUNIT_ASSERT(!rParameter2.getDescription().isEmpty()); } #endif // HAVE_MORE_FONTS |