diff options
author | Caolán McNamara <caolanm@redhat.com> | 2015-05-25 09:35:57 +0100 |
---|---|---|
committer | Caolán McNamara <caolanm@redhat.com> | 2015-05-25 12:32:54 +0100 |
commit | acad8441cc40b7b0f91681d6827f8364de05046e (patch) | |
tree | 2be1315764dc269557a60fb36a48d86b7ed23402 /vcl/qa | |
parent | 12b6bca821a7b0137fcac243f8aa078ba1a152ad (diff) |
cppcheck: noExplicitConstructor
Change-Id: I62076450ab77472bfd09b3fb9824f54b6ea1e0f7
Diffstat (limited to 'vcl/qa')
-rw-r--r-- | vcl/qa/cppunit/dndtest.cxx | 8 | ||||
-rw-r--r-- | vcl/qa/cppunit/lifecycle.cxx | 5 | ||||
-rw-r--r-- | vcl/qa/cppunit/timer.cxx | 6 |
3 files changed, 9 insertions, 10 deletions
diff --git a/vcl/qa/cppunit/dndtest.cxx b/vcl/qa/cppunit/dndtest.cxx index 7e502faf2372..64da3070d1cd 100644 --- a/vcl/qa/cppunit/dndtest.cxx +++ b/vcl/qa/cppunit/dndtest.cxx @@ -65,7 +65,7 @@ class MyDragAndDropListener: public ::cppu::WeakImplHelper3 < XDropTargetListene public: - MyDragAndDropListener( vcl::Window * pWindow ) : m_pWindow( pWindow ) {}; + explicit MyDragAndDropListener( vcl::Window * pWindow ) : m_pWindow( pWindow ) {}; virtual void SAL_CALL dragGestureRecognized( const DragGestureEvent& dge ) throw(RuntimeException); virtual void SAL_CALL drop( const DropTargetDropEvent& dtde ) throw(RuntimeException); @@ -86,7 +86,7 @@ class MyInfoBox : public InfoBox public: - MyInfoBox( vcl::Window* pParent ); + explicit MyInfoBox( vcl::Window* pParent ); }; class MyListBox : public ListBox @@ -94,7 +94,7 @@ class MyListBox : public ListBox public: - MyListBox( vcl::Window* pParent ); + explicit MyListBox( vcl::Window* pParent ); }; class StringTransferable : public ::cppu::WeakImplHelper1< XTransferable > @@ -103,7 +103,7 @@ class StringTransferable : public ::cppu::WeakImplHelper1< XTransferable > Sequence< DataFlavor > m_aFlavorList; public: - StringTransferable( const OUString& rString ) : m_aData( rString ), m_aFlavorList( 1 ) + explicit StringTransferable( const OUString& rString ) : m_aData( rString ), m_aFlavorList( 1 ) { DataFlavor df; diff --git a/vcl/qa/cppunit/lifecycle.cxx b/vcl/qa/cppunit/lifecycle.cxx index 2a63e79dfefe..d3b15d0fb088 100644 --- a/vcl/qa/cppunit/lifecycle.cxx +++ b/vcl/qa/cppunit/lifecycle.cxx @@ -114,7 +114,7 @@ void LifecycleTest::testParentedWidgets() class DisposableChild : public vcl::Window { public: - DisposableChild(vcl::Window *pParent) : vcl::Window(pParent) {} + explicit DisposableChild(vcl::Window *pParent) : vcl::Window(pParent) {} virtual ~DisposableChild() { disposeOnce(); @@ -149,7 +149,7 @@ void LifecycleTest::testPostDispose() class FocusCrashPostDispose : public TabControl { public: - FocusCrashPostDispose(vcl::Window *pParent) : + explicit FocusCrashPostDispose(vcl::Window *pParent) : TabControl(pParent, 0) { } @@ -159,7 +159,6 @@ public: } virtual bool Notify( NotifyEvent& ) SAL_OVERRIDE { -// CPPUNIT_FAIL("notify"); return false; } virtual void GetFocus() SAL_OVERRIDE diff --git a/vcl/qa/cppunit/timer.cxx b/vcl/qa/cppunit/timer.cxx index 5b8128100e22..976853c88e7b 100644 --- a/vcl/qa/cppunit/timer.cxx +++ b/vcl/qa/cppunit/timer.cxx @@ -24,7 +24,7 @@ class WatchDog : public osl::Thread { sal_Int32 mnSeconds; public: - WatchDog(sal_Int32 nSeconds) : + explicit WatchDog(sal_Int32 nSeconds) : Thread(), mnSeconds( nSeconds ) { @@ -86,7 +86,7 @@ class IdleBool : public Idle { bool &mrBool; public: - IdleBool( bool &rBool ) : + explicit IdleBool( bool &rBool ) : Idle(), mrBool( rBool ) { SetPriority( SchedulerPriority::LOWEST ); @@ -176,7 +176,7 @@ void TimerTest::testAutoTimer() class YieldTimer : public Timer { public: - YieldTimer( sal_uLong nMS ) : Timer() + explicit YieldTimer( sal_uLong nMS ) : Timer() { SetTimeout( nMS ); Start(); |