diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2019-08-16 09:56:29 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2019-08-16 10:49:40 +0200 |
| commit | 92e42a0fde32e3f2dbe2c786a0e41547e4912b4b (patch) | |
| tree | f0b1ca67ded12686cfe96d775650992ed291b204 /vcl/qa | |
| parent | 34e83dd95260d534464ff9a61eddefdde136013c (diff) | |
Drop bogus check from TimerTest::testStopwatch
(that had been added with 6e13585508ca3c9b66c6571ad1eb42bfcb66ef0b "Add a
TaskStopwatch to interrupt idle loops"). For each StopwatchIdle, m_nIters
counts the calls to Invoke before it calls Stop (which it calls based on
tools::Time::GetSystemTicks calculations). But the number of such
GetSystemTicks() spent in each Invoke is nondeterministic (it can e.g. be
affected by the overall system load), so a2Idle may Stop prior to a1Idle and
thus have a lower nIter2 than nIter1.
Change-Id: I416eee9774c3605be25e9832b24dec7d9dcb00c2
Reviewed-on: https://gerrit.libreoffice.org/77561
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'vcl/qa')
| -rw-r--r-- | vcl/qa/cppunit/timer.cxx | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/vcl/qa/cppunit/timer.cxx b/vcl/qa/cppunit/timer.cxx index 39734ae18b85..1c5913d287de 100644 --- a/vcl/qa/cppunit/timer.cxx +++ b/vcl/qa/cppunit/timer.cxx @@ -595,7 +595,6 @@ void TimerTest::testStopwatch() bool b1Done = a1Idle.isDone(n1Iter); bool b2Done = a2Idle.isDone(n2Iter); - CPPUNIT_ASSERT(n1Iter >= n2Iter); if (b1Done && b2Done) break; |