summaryrefslogtreecommitdiff
path: root/vcl/qa
diff options
context:
space:
mode:
authorTor Lillqvist <tml@collabora.com>2016-06-02 15:21:39 +0300
committerTor Lillqvist <tml@collabora.com>2016-06-03 08:14:08 +0000
commit27d381f6c0fdf3240950f5906ae78fa340ad9d6f (patch)
treec60478b98b4b84ecb8e14d6bd46471b6413bbeb1 /vcl/qa
parentb6230835b927e0053687fae6026fa3603600f321 (diff)
Accept also hex vendor id in opengl_blacklist_windows.xml
(And not just names from the hardcoded list.) Surely we want it to be possible to add a blacklist entry for a hitherto unhandled vendor to the file at a user site without having to modify the parsing code and rebuilding LO. (cherry picked from commit 44e89fa6151434be24dca38c32b8cb952455f372) Change-Id: I01ca45cb91df06e1634a565b3e469fb85fe4e116 Reviewed-on: https://gerrit.libreoffice.org/25823 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
Diffstat (limited to 'vcl/qa')
-rw-r--r--vcl/qa/cppunit/blocklistparsertest.cxx7
-rwxr-xr-xvcl/qa/cppunit/test_blocklist_parse.xml6
2 files changed, 12 insertions, 1 deletions
diff --git a/vcl/qa/cppunit/blocklistparsertest.cxx b/vcl/qa/cppunit/blocklistparsertest.cxx
index 93817fd21d5f..ddad53b94a27 100644
--- a/vcl/qa/cppunit/blocklistparsertest.cxx
+++ b/vcl/qa/cppunit/blocklistparsertest.cxx
@@ -40,7 +40,7 @@ void BlocklistParserTest::testParse()
aBlocklistParser.parse();
size_t const n = aDriveInfos.size();
- CPPUNIT_ASSERT_EQUAL(static_cast<size_t>(20), n);
+ CPPUNIT_ASSERT_EQUAL(static_cast<size_t>(22), n);
size_t i = 0;
@@ -81,6 +81,11 @@ void BlocklistParserTest::testParse()
aDriveInfo = aDriveInfos[i++];
CPPUNIT_ASSERT_EQUAL(bIsWhitelisted, aDriveInfo.mbWhitelisted);
+ CPPUNIT_ASSERT_EQUAL(OUString("0xcafe"), aDriveInfo.maAdapterVendor);
+ CPPUNIT_ASSERT_EQUAL(wgl::VersionComparisonOp::DRIVER_NOT_EQUAL, aDriveInfo.meComparisonOp);
+
+ aDriveInfo = aDriveInfos[i++];
+ CPPUNIT_ASSERT_EQUAL(bIsWhitelisted, aDriveInfo.mbWhitelisted);
CPPUNIT_ASSERT_EQUAL(WinOpenGLDeviceInfo::GetDeviceVendor(wgl::VendorAll), aDriveInfo.maAdapterVendor);
CPPUNIT_ASSERT_EQUAL(wgl::VersionComparisonOp::DRIVER_BETWEEN_EXCLUSIVE, aDriveInfo.meComparisonOp);
diff --git a/vcl/qa/cppunit/test_blocklist_parse.xml b/vcl/qa/cppunit/test_blocklist_parse.xml
index 65646685aa7d..72ba4059115a 100755
--- a/vcl/qa/cppunit/test_blocklist_parse.xml
+++ b/vcl/qa/cppunit/test_blocklist_parse.xml
@@ -27,6 +27,9 @@
<entry os="8" vendor="microsoft" compare="not_equal" version="10.20.30.40">
<device id="all"/>
</entry>
+ <entry os="8" vendor="0xcafe" compare="not_equal" version="10.20.30.40">
+ <device id="all"/>
+ </entry>
<entry os="8_1" compare="between_exclusive" version="10.20.30.40">
<device id="all"/>
</entry>
@@ -59,6 +62,9 @@
<entry os="8" vendor="microsoft" compare="not_equal" version="10.20.30.40">
<device id="all"/>
</entry>
+ <entry os="8" vendor="0xcafe" compare="not_equal" version="10.20.30.40">
+ <device id="all"/>
+ </entry>
<entry os="8_1" compare="between_exclusive" version="10.20.30.40">
<device id="all"/>
</entry>