diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-06-02 10:40:26 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-06-03 10:51:57 +0200 |
| commit | 054c0e7177cbef26942f8ca7cb7b1422ceea721c (patch) | |
| tree | 7390a1be5ee0797b7f43d7d433822315fd75c6dd /vcl/qa | |
| parent | 0f499af8c2c22ccc8f1c19edeeb2bdac8cbcb7f0 (diff) | |
loplugin:simplifypointertobool improve
to look for the
x.get() != null
pattern, which can be simplified to
x
I'll do the
x.get() == nullptr
pattern in a separate patch, to reduce the chances of a mistake
Change-Id: I45e0d178e75359857cdf50d712039cb526016555
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95354
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'vcl/qa')
| -rw-r--r-- | vcl/qa/cppunit/lifecycle.cxx | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/vcl/qa/cppunit/lifecycle.cxx b/vcl/qa/cppunit/lifecycle.cxx index a4a3f5d9e3d2..078fb3266623 100644 --- a/vcl/qa/cppunit/lifecycle.cxx +++ b/vcl/qa/cppunit/lifecycle.cxx @@ -83,7 +83,7 @@ void LifecycleTest::testVirtualDevice() void LifecycleTest::testMultiDispose() { VclPtrInstance<WorkWindow> xWin(nullptr, WB_APP|WB_STDWORK); - CPPUNIT_ASSERT(xWin.get() != nullptr); + CPPUNIT_ASSERT(xWin); xWin->disposeOnce(); xWin->disposeOnce(); xWin->disposeOnce(); @@ -141,7 +141,7 @@ void LifecycleTest::testIsolatedWidgets() void LifecycleTest::testParentedWidgets() { ScopedVclPtrInstance<WorkWindow> xWin(nullptr, WB_APP|WB_STDWORK); - CPPUNIT_ASSERT(xWin.get() != nullptr); + CPPUNIT_ASSERT(xWin); xWin->Show(); testWidgets(xWin); } @@ -163,7 +163,7 @@ public: void LifecycleTest::testChildDispose() { VclPtrInstance<WorkWindow> xWin(nullptr, WB_APP|WB_STDWORK); - CPPUNIT_ASSERT(xWin.get() != nullptr); + CPPUNIT_ASSERT(xWin); VclPtrInstance< DisposableChild > xChild( xWin.get() ); xWin->Show(); xChild->disposeOnce(); |