diff options
| author | Mike Kaganski <mike.kaganski@collabora.com> | 2021-10-14 09:25:24 +0200 |
|---|---|---|
| committer | Mike Kaganski <mike.kaganski@collabora.com> | 2021-10-15 10:36:36 +0200 |
| commit | 2484de6728bd11bb7949003d112f1ece2223c7a1 (patch) | |
| tree | 1296534e396da284b38d2c478dcd2b31c4714179 /vcl/qa | |
| parent | 88375fd36899d21d3309cf8333712e02a87d3a91 (diff) | |
Remove non-const Sequence::begin()/end() in internal code
... to avoid hidden cost of multiple COW checks, because they
call getArray() internally.
This obsoletes [loplugin:sequenceloop].
Also rename toNonConstRange to asNonConstRange, to reflect that
the result is a view of the sequence, not an independent object.
TODO: also drop non-const operator[], but introduce operator[]
in SequenceRange.
Change-Id: Idd5fd7a3400fe65274d2a6343025e2ef8911635d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123518
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'vcl/qa')
| -rw-r--r-- | vcl/qa/cppunit/canvasbitmaptest.cxx | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/vcl/qa/cppunit/canvasbitmaptest.cxx b/vcl/qa/cppunit/canvasbitmaptest.cxx index 9b50282ee8b0..10923d8704f2 100644 --- a/vcl/qa/cppunit/canvasbitmaptest.cxx +++ b/vcl/qa/cppunit/canvasbitmaptest.cxx @@ -499,7 +499,7 @@ private: { const uno::Sequence< rendering::ARGBColor > aTemp( convertIntegerToARGB(deviceColor) ); uno::Sequence< rendering::RGBColor > aRes( aTemp.getLength() ); - std::transform(aTemp.begin(), aTemp.end(), aRes.begin(), + std::transform(aTemp.begin(), aTemp.end(), aRes.getArray(), [](const rendering::ARGBColor& rColor) { return rendering::RGBColor(rColor.Red, rColor.Green, @@ -520,7 +520,7 @@ private: if( getPalette().is() ) { - std::transform(deviceColor.begin(), deviceColor.end(), aRes.begin(), + std::transform(deviceColor.begin(), deviceColor.end(), aRes.getArray(), [](sal_Int8 nIn) { auto fColor = vcl::unotools::toDoubleColor(nIn); return rendering::ARGBColor(1.0, fColor, fColor, fColor); @@ -554,7 +554,7 @@ private: if( getPalette().is() ) { - std::transform(deviceColor.begin(), deviceColor.end(), aRes.begin(), + std::transform(deviceColor.begin(), deviceColor.end(), aRes.getArray(), [](sal_Int8 nIn) { auto fColor = vcl::unotools::toDoubleColor(nIn); return rendering::ARGBColor(1.0, fColor, fColor, fColor); |