loplugin:constfields in vcl

Change-Id: I1072642be4fdfa720e61f2d7bad3c2701eb81610
Reviewed-on: https://gerrit.libreoffice.org/60430
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

5 files changed, 12 insertions, 18 deletions

diff --git a/vcl/qa/api/XGraphicTest.cxx b/vcl/qa/api/XGraphicTest.cxx
index 1dc9a1c1fe65..0272c24645cc 100644
--- a/vcl/qa/api/XGraphicTest.cxx
+++ b/vcl/qa/api/XGraphicTest.cxx
@@ -26,20 +26,19 @@ namespace
 {
 using namespace css;
 
+static OUString const gaDataUrl = "/vcl/qa/api/data/";
+
 class XGraphicTest : public test::BootstrapFixture
 {
 public:
-    OUString maDataUrl;
-
     XGraphicTest()
         : BootstrapFixture(true, false)
-        , maDataUrl("/vcl/qa/api/data/")
     {
     }
 
     OUString getFullUrl(const OUString& sFileName)
     {
-        return m_directories.getURLFromSrc(maDataUrl) + sFileName;
+        return m_directories.getURLFromSrc(gaDataUrl) + sFileName;
     }
 
     void testGraphic();
diff --git a/vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx b/vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx
index c2455e1e4e16..b6f2dbbd3d99 100644
--- a/vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx
+++ b/vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx
@@ -20,19 +20,18 @@
 
 #include <vcl/graphicfilter.hxx>
 
+static OUString const gaDataUrl = "/vcl/qa/cppunit/bitmaprender/data/";
+
 class BitmapRenderTest : public test::BootstrapFixture
 {
-    OUString maDataUrl;
-
     OUString getFullUrl(const OUString& sFileName)
     {
-        return m_directories.getURLFromSrc(maDataUrl) + sFileName;
+        return m_directories.getURLFromSrc(gaDataUrl) + sFileName;
     }
 
 public:
     BitmapRenderTest()
         : BootstrapFixture(true, false)
-        , maDataUrl("/vcl/qa/cppunit/bitmaprender/data/")
     {
     }
 
diff --git a/vcl/qa/cppunit/canvasbitmaptest.cxx b/vcl/qa/cppunit/canvasbitmaptest.cxx
index 52d3769ce74e..8cbbae5496a0 100644
--- a/vcl/qa/cppunit/canvasbitmaptest.cxx
+++ b/vcl/qa/cppunit/canvasbitmaptest.cxx
@@ -245,7 +245,7 @@ class TestBitmap : public cppu::WeakImplHelper< rendering::XIntegerReadOnlyBitma
                                                  rendering::XIntegerBitmapColorSpace >
 {
 private:
-    geometry::IntegerSize2D        maSize;
+    geometry::IntegerSize2D const  maSize;
     uno::Sequence<sal_Int8>        maComponentTags;
     uno::Sequence<sal_Int32>       maComponentBitCounts;
     rendering::IntegerBitmapLayout maLayout;
diff --git a/vcl/qa/cppunit/jpeg/JpegReaderTest.cxx b/vcl/qa/cppunit/jpeg/JpegReaderTest.cxx
index f9a780187d51..d63b6b276a58 100644
--- a/vcl/qa/cppunit/jpeg/JpegReaderTest.cxx
+++ b/vcl/qa/cppunit/jpeg/JpegReaderTest.cxx
@@ -14,22 +14,18 @@
 #include <vcl/bitmapaccess.hxx>
 #include <bitmapwriteaccess.hxx>
 
+static OUString const gaDataUrl("/vcl/qa/cppunit/jpeg/data/");
+
 class JpegReaderTest : public test::BootstrapFixtureBase
 {
-    OUString maDataUrl;
-
     OUString getFullUrl(const OUString& sFileName)
     {
-        return m_directories.getURLFromSrc(maDataUrl) + sFileName;
+        return m_directories.getURLFromSrc(gaDataUrl) + sFileName;
     }
 
     Graphic loadJPG(const OUString& aURL);
 
 public:
-    JpegReaderTest() :
-        maDataUrl("/vcl/qa/cppunit/jpeg/data/")
-    {}
-
     void testReadRGB();
     void testReadGray();
     void testReadCMYK();
diff --git a/vcl/qa/cppunit/timer.cxx b/vcl/qa/cppunit/timer.cxx
index 1e57f27884bd..4c4ed630c601 100644
--- a/vcl/qa/cppunit/timer.cxx
+++ b/vcl/qa/cppunit/timer.cxx
@@ -31,7 +31,7 @@
 /// Avoid our timer tests just wedging the build if they fail.
 class WatchDog : public osl::Thread
 {
-    sal_Int32 mnSeconds;
+    sal_Int32 const mnSeconds;
 public:
     explicit WatchDog(sal_Int32 nSeconds) :
         Thread(),
@@ -450,7 +450,7 @@ void TimerTest::testInvokedReStart()
 
 class IdleSerializer : public Idle
 {
-    sal_uInt32 mnPosition;
+    sal_uInt32 const mnPosition;
     sal_uInt32 &mrProcesed;
 public:
     IdleSerializer( const sal_Char *pDebugName,