diff options
| author | Khaled Hosny <khaled@aliftype.com> | 2022-08-23 22:35:10 +0200 |
|---|---|---|
| committer | Tomaž Vajngerl <quikee@gmail.com> | 2022-08-25 13:02:14 +0200 |
| commit | 7581fcde3c6a8d098a37b2c89c74e54696d4c346 (patch) | |
| tree | 62b0089ca277eb4a2c22af769669ce2d8514d56f /vcl/qa | |
| parent | 187be4a26f38af6a0c8751a096379978e269a83a (diff) | |
FeatureCollector: Simplify
We are not using the script or language information for anything, so we
can use HarfBuzz API to query the GSUB/GPOS tables directly.
Change-Id: Ie68c51a1662494ba33ec192edb78afa0d8added4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138745
Tested-by: خالد حسني <khaled@aliftype.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Diffstat (limited to 'vcl/qa')
| -rw-r--r-- | vcl/qa/cppunit/FontFeatureTest.cxx | 19 |
1 files changed, 6 insertions, 13 deletions
diff --git a/vcl/qa/cppunit/FontFeatureTest.cxx b/vcl/qa/cppunit/FontFeatureTest.cxx index 0e9ada19cdd4..91bcda29b74f 100644 --- a/vcl/qa/cppunit/FontFeatureTest.cxx +++ b/vcl/qa/cppunit/FontFeatureTest.cxx @@ -54,20 +54,13 @@ void FontFeatureTest::testGetFontFeatures() std::vector<vcl::font::Feature> rFontFeatures; CPPUNIT_ASSERT(aVDev->GetFontFeatures(rFontFeatures)); - // We're interested only in defaults here - std::vector<vcl::font::Feature> rDefaultFontFeatures; OUString aFeaturesString; for (vcl::font::Feature const& rFeature : rFontFeatures) { - if (rFeature.m_aID.m_aScriptCode == vcl::font::featureCode("DFLT") - && rFeature.m_aID.m_aLanguageCode == vcl::font::featureCode("dflt")) - { - rDefaultFontFeatures.push_back(rFeature); - aFeaturesString += vcl::font::featureCodeAsString(rFeature.m_aID.m_aFeatureCode) + " "; - } + aFeaturesString += vcl::font::featureCodeAsString(rFeature.m_nCode) + " "; } - CPPUNIT_ASSERT_EQUAL(size_t(53), rDefaultFontFeatures.size()); + CPPUNIT_ASSERT_EQUAL(size_t(53), rFontFeatures.size()); CPPUNIT_ASSERT_EQUAL(OUString("c2sc case dlig fina frac hlig liga lnum " "locl onum pnum sa01 sa02 sa03 sa04 sa05 " @@ -80,8 +73,8 @@ void FontFeatureTest::testGetFontFeatures() // Check C2SC feature { - vcl::font::Feature& rFeature = rDefaultFontFeatures[0]; - CPPUNIT_ASSERT_EQUAL(vcl::font::featureCode("c2sc"), rFeature.m_aID.m_aFeatureCode); + vcl::font::Feature& rFeature = rFontFeatures[0]; + CPPUNIT_ASSERT_EQUAL(vcl::font::featureCode("c2sc"), rFeature.m_nCode); vcl::font::FeatureDefinition& rFracFeatureDefinition = rFeature.m_aDefinition; CPPUNIT_ASSERT_EQUAL(vcl::font::featureCode("c2sc"), rFracFeatureDefinition.getCode()); @@ -94,8 +87,8 @@ void FontFeatureTest::testGetFontFeatures() // Check FRAC feature { - vcl::font::Feature& rFeature = rDefaultFontFeatures[4]; - CPPUNIT_ASSERT_EQUAL(vcl::font::featureCode("frac"), rFeature.m_aID.m_aFeatureCode); + vcl::font::Feature& rFeature = rFontFeatures[4]; + CPPUNIT_ASSERT_EQUAL(vcl::font::featureCode("frac"), rFeature.m_nCode); vcl::font::FeatureDefinition& rFracFeatureDefinition = rFeature.m_aDefinition; CPPUNIT_ASSERT_EQUAL(vcl::font::featureCode("frac"), rFracFeatureDefinition.getCode()); |