diff options
| author | Luboš Luňák <l.lunak@collabora.com> | 2019-10-12 20:15:29 +0200 |
|---|---|---|
| committer | Luboš Luňák <l.lunak@collabora.com> | 2019-11-27 09:55:07 +0100 |
| commit | 8f5c2a559ac4190db36a1fa85ba965f3cceab5ed (patch) | |
| tree | 5e7a5aeb896d13c78d631a69cc352715c0efa5b8 /vcl/qa | |
| parent | 856ac32933442378f7e21d1ec6015adcbc2e95b2 (diff) | |
disable bitmap CRC checking in SvmTest::checkBitmap(Ex)s() for Skia
The idea itself is broken, the CRC depends on the scaling algorithm
and also on the exact internal layout (and if scanlines are rounded
up, the CRC also depends on random bytes).
Change-Id: I800be8553c7f2afce1a4c292cd61369cde0ba6c3
Diffstat (limited to 'vcl/qa')
| -rw-r--r-- | vcl/qa/cppunit/svm/svmtest.cxx | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/vcl/qa/cppunit/svm/svmtest.cxx b/vcl/qa/cppunit/svm/svmtest.cxx index 5b2330a67805..e834f5b954f5 100644 --- a/vcl/qa/cppunit/svm/svmtest.cxx +++ b/vcl/qa/cppunit/svm/svmtest.cxx @@ -22,6 +22,7 @@ #if HAVE_FEATURE_OPENGL #include <vcl/opengl/OpenGLHelper.hxx> #endif +#include <vcl/skia/SkiaHelper.hxx> using namespace css; @@ -914,6 +915,9 @@ void SvmTest::checkBitmaps(const GDIMetaFile& rMetaFile) { xmlDocPtr pDoc = dumpMeta(rMetaFile); + if (SkiaHelper::isVCLSkiaEnabled()) + return; // TODO SKIA using CRCs is broken (the idea of it) + OUString crc1 = "b8dee5da"; OUString crc2 = "281fc589"; OUString crc3 = "5e01ddcc"; @@ -979,6 +983,9 @@ void SvmTest::checkBitmapExs(const GDIMetaFile& rMetaFile) { xmlDocPtr pDoc = dumpMeta(rMetaFile); + if (SkiaHelper::isVCLSkiaEnabled()) + return; // TODO SKIA using CRCs is broken (the idea of it) + std::vector<OUString> aExpectedCRC; #if HAVE_FEATURE_OPENGL |