make the Color constructors explicitly specify transparency

to reduce the churn, we leave the existing constructor in place,
and add a clang plugin to detect when the value passed to the
existing constructor may contain transparency/alpha data.

i.e. we leave expressions like Color(0xffffff) alone, but
warn about any non-constant expression, and any expression
like Color(0xff000000)

Change-Id: Id2ce58e08882d9b7bd0b9f88eca97359dcdbcc8c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109362
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 2 insertions, 2 deletions

diff --git a/vcl/qt5/Qt5AccessibleWidget.cxx b/vcl/qt5/Qt5AccessibleWidget.cxx
index 1f33cec86e3c..879c451ec277 100644
--- a/vcl/qt5/Qt5AccessibleWidget.cxx
+++ b/vcl/qt5/Qt5AccessibleWidget.cxx
@@ -666,7 +666,7 @@ QColor Qt5AccessibleWidget::foregroundColor() const
         return QColor();
 
     Reference<XAccessibleComponent> xAccessibleComponent(xAc, UNO_QUERY);
-    return toQColor(xAccessibleComponent->getForeground());
+    return toQColor(Color(ColorTransparency, xAccessibleComponent->getForeground()));
 }
 
 QColor Qt5AccessibleWidget::backgroundColor() const
@@ -676,7 +676,7 @@ QColor Qt5AccessibleWidget::backgroundColor() const
         return QColor();
 
     Reference<XAccessibleComponent> xAccessibleComponent(xAc, UNO_QUERY);
-    return toQColor(xAccessibleComponent->getBackground());
+    return toQColor(Color(ColorTransparency, xAccessibleComponent->getBackground()));
 }
 
 void* Qt5AccessibleWidget::interface_cast(QAccessible::InterfaceType t)