diff options
| author | Michael Weghorn <m.weghorn@posteo.de> | 2024-11-07 23:30:59 +0100 |
|---|---|---|
| committer | Michael Weghorn <m.weghorn@posteo.de> | 2024-11-08 08:39:45 +0100 |
| commit | aae76f4df1d4a554fa16c05a28d2e1d10ea558af (patch) | |
| tree | fdacbd6fc0bf02eae02af19a043efcb273cb2b35 /vcl/qt5 | |
| parent | 7ede3b80bc9ce7c99637f4d2bbc9662cf1b77b65 (diff) | |
tdf#130857 vcl: Move weld::Window::{g,s}et_modal to weld::Dialog
All calls to get_modal and set_modal are done for weld::Dialog
instances, never for plain instances of/pointers to the weld::Window
base class.
Therefore, drop the methods from weld::Window and add them weld::Dialog
instead.
SalInstanceDialog was already overriding the SalInstanceWindow
implementations of both methods.
For QtInstanceWindow, these were not implemented yet, while
QtInstanceDialog already has implementations.
(If there were a real need, they could be implemented using
QWidget::isModal/QWidget::windowModality and
QWidget::setWindowModality.)
For GTK, move the GtkInstanceWindow::get_modal implementation
to GtkInstanceDialog and call gtk_window_set_modal directly
instead of GtkInstanceWindow::set_modal in
GtkInstanceDialog::set_modal.
Change-Id: I71431347f3bca9571c6fd4b7cf995bb79fb5b11d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176252
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Diffstat (limited to 'vcl/qt5')
| -rw-r--r-- | vcl/qt5/QtInstanceWindow.cxx | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/vcl/qt5/QtInstanceWindow.cxx b/vcl/qt5/QtInstanceWindow.cxx index a915dd373131..a3c6b3de3687 100644 --- a/vcl/qt5/QtInstanceWindow.cxx +++ b/vcl/qt5/QtInstanceWindow.cxx @@ -45,10 +45,6 @@ OUString QtInstanceWindow::get_title() const void QtInstanceWindow::window_move(int, int) {} -void QtInstanceWindow::set_modal(bool) {} - -bool QtInstanceWindow::get_modal() const { return true; } - bool QtInstanceWindow::get_resizable() const { return true; } Size QtInstanceWindow::get_size() const { return Size(); } |