diff options
author | Jan-Marek Glogowski <glogow@fbihome.de> | 2019-05-03 21:18:34 +0200 |
---|---|---|
committer | Jan-Marek Glogowski <glogow@fbihome.de> | 2019-05-05 00:57:52 +0200 |
commit | da3103365f9574307f70f3f2bae2a3dc461915c1 (patch) | |
tree | 8ab7fbbfbbc2437caa07b2fd791434b15262f1e4 /vcl/qt5 | |
parent | 110fd705ad3ae35144aaa6e5d8249b7e35f2825f (diff) |
tdf#123957 Qt5 IM generate correct formating
Actually really evaluate some of the formating provided by the
QInputMethodEvent::TextFormat attribute and not blindly underline
all of the text. This evaluates the same formating that the gtk3
backend evaluates from pango, so the result should be somehow on
par. Couldn't find a way to test the red strike-out text.
Don't know how often I typed hyoujunnsutairu to test this bug,
which - according to Google - translates to "standard style".
Change-Id: I4263df6dc1e0e5ce5d8cb0be681656ccd662a830
Reviewed-on: https://gerrit.libreoffice.org/71783
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
Diffstat (limited to 'vcl/qt5')
-rw-r--r-- | vcl/qt5/Qt5Widget.cxx | 41 |
1 files changed, 38 insertions, 3 deletions
diff --git a/vcl/qt5/Qt5Widget.cxx b/vcl/qt5/Qt5Widget.cxx index 1b5030f376ef..bef3c61798b4 100644 --- a/vcl/qt5/Qt5Widget.cxx +++ b/vcl/qt5/Qt5Widget.cxx @@ -34,6 +34,7 @@ #include <QtGui/QPaintEvent> #include <QtGui/QResizeEvent> #include <QtGui/QShowEvent> +#include <QtGui/QTextCharFormat> #include <QtGui/QWheelEvent> #include <QtWidgets/QMainWindow> #include <QtWidgets/QToolTip> @@ -449,6 +450,24 @@ Qt5Widget::Qt5Widget(Qt5Frame& rFrame, Qt::WindowFlags f) setFocusPolicy(Qt::StrongFocus); } +static ExtTextInputAttr lcl_MapUndrelineStyle(QTextCharFormat::UnderlineStyle us) +{ + switch (us) + { + case QTextCharFormat::NoUnderline: + return ExtTextInputAttr::NONE; + case QTextCharFormat::DotLine: + return ExtTextInputAttr::DottedUnderline; + case QTextCharFormat::DashDotDotLine: + case QTextCharFormat::DashDotLine: + return ExtTextInputAttr::DashDotUnderline; + case QTextCharFormat::WaveUnderline: + return ExtTextInputAttr::GrayWaveline; + default: + return ExtTextInputAttr::Underline; + } +} + void Qt5Widget::inputMethodEvent(QInputMethodEvent* pEvent) { SolarMutexGuard aGuard; @@ -473,13 +492,31 @@ void Qt5Widget::inputMethodEvent(QInputMethodEvent* pEvent) const sal_Int32 nLength = aInputEvent.maText.getLength(); const QList<QInputMethodEvent::Attribute>& rAttrList = pEvent->attributes(); - std::vector<ExtTextInputAttr> aTextAttrs(nLength, ExtTextInputAttr::Underline); + std::vector<ExtTextInputAttr> aTextAttrs(std::max(1, nLength), ExtTextInputAttr::NONE); + aInputEvent.mpTextAttr = &aTextAttrs[0]; for (int i = 0; i < rAttrList.size(); ++i) { const QInputMethodEvent::Attribute& rAttr = rAttrList.at(i); switch (rAttr.type) { + case QInputMethodEvent::TextFormat: + { + QTextCharFormat aCharFormat + = qvariant_cast<QTextFormat>(rAttr.value).toCharFormat(); + if (aCharFormat.isValid()) + { + ExtTextInputAttr aETIP + = lcl_MapUndrelineStyle(aCharFormat.underlineStyle()); + if (aCharFormat.hasProperty(QTextFormat::BackgroundBrush)) + aETIP |= ExtTextInputAttr::Highlight; + if (aCharFormat.fontStrikeOut()) + aETIP |= ExtTextInputAttr::RedText; + for (int j = rAttr.start; j < rAttr.start + rAttr.length; j++) + aTextAttrs[j] = aETIP; + } + break; + } case QInputMethodEvent::Cursor: { aInputEvent.mnCursorPos = rAttr.start; @@ -493,8 +530,6 @@ void Qt5Widget::inputMethodEvent(QInputMethodEvent* pEvent) break; } } - if (nLength) - aInputEvent.mpTextAttr = &aTextAttrs[0]; m_pFrame->CallCallback(SalEvent::ExtTextInput, &aInputEvent); pEvent->accept(); |