diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-09-06 14:33:24 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-09-06 17:16:34 +0200 |
| commit | bce47223099bb3349d96af9d6b1fe88bcdd539df (patch) | |
| tree | 21e71197cf83f80657914bb529c459208a01547a /vcl/source/graphic | |
| parent | f4d4b100ffd18993d4eab1bcd52fe12b7f8f3e32 (diff) | |
clang-tidy bugprone-use-after-move in BitmapFilter::Filter
which necesitated changing the API and hence the call sites
Change-Id: Id417a235bf9b2bf1a3d152dc6600c0635486cafa
Reviewed-on: https://gerrit.libreoffice.org/60086
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'vcl/source/graphic')
| -rw-r--r-- | vcl/source/graphic/UnoGraphicTransformer.cxx | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/vcl/source/graphic/UnoGraphicTransformer.cxx b/vcl/source/graphic/UnoGraphicTransformer.cxx index 2fba69d01c93..b749014ffe44 100644 --- a/vcl/source/graphic/UnoGraphicTransformer.cxx +++ b/vcl/source/graphic/UnoGraphicTransformer.cxx @@ -122,7 +122,8 @@ uno::Reference< graphic::XGraphic > SAL_CALL GraphicTransformer::applyDuotone( Bitmap aBitmap( aBitmapEx.GetBitmap() ); BitmapEx aTmpBmpEx(aBitmap); - BitmapFilter::Filter(aTmpBmpEx, BitmapDuoToneFilter(static_cast<sal_uLong>(nColorOne), static_cast<sal_uLong>(nColorTwo))); + BitmapDuoToneFilter filter(static_cast<sal_uLong>(nColorOne), static_cast<sal_uLong>(nColorTwo)); + BitmapFilter::Filter(aTmpBmpEx, filter); aBitmap = aTmpBmpEx.GetBitmap(); aReturnGraphic = ::Graphic( BitmapEx( aBitmap, aMask ) ); |